Skip to content

ESLint: Migrate to use 'import-x' plugin#33105

Merged
ndelangen merged 5 commits into
storybookjs:nextfrom
sakit0:fix-eslint-plugin-import
Dec 22, 2025
Merged

ESLint: Migrate to use 'import-x' plugin#33105
ndelangen merged 5 commits into
storybookjs:nextfrom
sakit0:fix-eslint-plugin-import

Conversation

@sakit0
Copy link
Copy Markdown
Contributor

@sakit0 sakit0 commented Nov 20, 2025

Closes #31672

What I did

The eslint-plugin-import has been deprecated, so i have migrated to eslint-plugin-import-x.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Run lint.

  • storybook/code : yarn lint
  • storybook/script : yarn lint

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Chores
    • Switched ESLint import plugin to a newer plugin namespace and updated related rule keys across configurations.
    • Standardized lint directives and plugin entries in project and script configs to ensure consistent import linting behavior.
    • Updated dependency declarations to reference the new import plugin version for unified validation.

✏️ Tip: You can customize this high-level summary in your review settings.

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Nov 20, 2025

View your CI Pipeline Execution ↗ for commit 91a354b


☁️ Nx Cloud last updated this comment at 2025-12-22 22:17:00 UTC

@coderabbitai

This comment was marked as spam.

@storybook-app-bot
Copy link
Copy Markdown

storybook-app-bot Bot commented Nov 24, 2025

Package Benchmarks

Commit: 91a354b, ran on 22 December 2025 at 22:28:35 UTC

No significant changes detected, all good. 👏

@github-actions github-actions Bot added the Stale label Dec 6, 2025
…slint-plugin-import-x, add stable-hash-x, and update @typescript-eslint/types. Remove unused dependencies and clean up version specifications.
@ndelangen ndelangen changed the title Refactor ESLint configuration to use 'import-x' plugin, updating rule… ESLint: Migrate to use 'import-x' plugin Dec 22, 2025
@ndelangen ndelangen removed the Stale label Dec 22, 2025
@ndelangen ndelangen merged commit c4f75cb into storybookjs:next Dec 22, 2025
58 of 64 checks passed
@github-actions github-actions Bot mentioned this pull request Dec 22, 2025
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:normal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Repo]: migrate eslint-plugin-import to eslint-plugin-import-x

3 participants