Skip to content

Remove yarn esbuild pnp plugin #33097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valentinpalkovic merged 1 commit into from
Nov 24, 2025
Merged

Remove yarn esbuild pnp plugin #33097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion code/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,6 @@
"@types/semver": "^7.5.8",
"@types/ws": "^8",
"@vitest/utils": "^3.2.4",
"@yarnpkg/esbuild-plugin-pnp": "^3.0.0-rc.10",
"@yarnpkg/fslib": "2.10.3",
"@yarnpkg/libzip": "2.3.0",
"ansi-to-html": "^0.7.2",
Expand Down
4 changes: 1 addition & 3 deletions code/core/src/builder-manager/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ import { stringifyProcessEnvs } from 'storybook/internal/common';
import { logger } from 'storybook/internal/node-logger';

import { globalExternals } from '@fal-works/esbuild-plugin-global-externals';
// TODO: Remove in SB11
import { pnpPlugin } from '@yarnpkg/esbuild-plugin-pnp';
import { resolveModulePath } from 'exsolve';
import { join, parse } from 'pathe';
import sirv from 'sirv';
Expand Down Expand Up @@ -104,7 +102,7 @@ export const getConfig: ManagerBuilder['getConfig'] = async (options) => {
tsconfig: tsconfigPath,

legalComments: 'external',
plugins: [globalExternals(globalsModuleInfoMap), pnpPlugin()],
plugins: [globalExternals(globalsModuleInfoMap)],

banner: {
js: 'try{',
Expand Down
12 changes: 0 additions & 12 deletions code/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10825,17 +10825,6 @@ __metadata:
languageName: node
linkType: hard

"@yarnpkg/esbuild-plugin-pnp@npm:^3.0.0-rc.10":
version: 3.0.0-rc.15
resolution: "@yarnpkg/esbuild-plugin-pnp@npm:3.0.0-rc.15"
dependencies:
tslib: "npm:^2.4.0"
peerDependencies:
esbuild: ">=0.10.0"
checksum: 10c0/5095bc316862971add31ca1fadb0095b6ad15f25120f6ab3a06086bb6a7be93c2f3c45bff80d5976689fc89b0e9bf82bd3d410e205c852739874d32d050c4e57
languageName: node
linkType: hard

"@yarnpkg/fslib@npm:2.10.3":
version: 2.10.3
resolution: "@yarnpkg/fslib@npm:2.10.3"
Expand Down Expand Up @@ -25937,7 +25926,6 @@ __metadata:
"@vitest/expect": "npm:3.2.4"
"@vitest/spy": "npm:3.2.4"
"@vitest/utils": "npm:^3.2.4"
"@yarnpkg/esbuild-plugin-pnp": "npm:^3.0.0-rc.10"
"@yarnpkg/fslib": "npm:2.10.3"
"@yarnpkg/libzip": "npm:2.3.0"
ansi-to-html: "npm:^0.7.2"
Expand Down
Loading