Danger: Fix the config file#33073
Merged
Merged
Conversation
ndelangen
changed the title
…d streamline label checks
|
View your CI Pipeline Execution ↗ for commit a9c37f6
☁️ Nx Cloud last updated this comment at |
…xtension and add new Dangerfile script for PR label checks
…xtension and add new Dangerfile script for PR label validation and title checks
…on path resolution
ndelangen
added
ci:docs
yannbf
approved these changes
Nov 18, 2025
Member
yannbf
left a comment
yannbf
left a comment
There was a problem hiding this comment.
LGTM. Can you make the PR fail on danger just to check its functionality? Like remove a label or something
…tension and add new Dangerfile script for PR label validation and title checks
ndelangen
commented
Nov 18, 2025
Comment on lines
+1
to
+14
| /** | ||
| * IMPORTANT: This file has unique constraints due to how Danger.js executes it. | ||
| * | ||
| * Restrictions: | ||
| * - NO TypeScript: This file runs without any transpilation/transformation | ||
| * - NO external dependencies: Scripts dependencies are not installed in CI | ||
| * - NO Node.js built-ins: Even `fs` and other core modules don't work in Danger's runtime | ||
| * - MUST use `import` for Danger API: The Danger runtime only processes `import` statements, | ||
| * not `require()`. These imports get compiled to global references by Danger.js | ||
| * - CAN use `require()` for local files: Works for things like package.json | ||
| * | ||
| * Why: We want Danger to run as fast as possible in CI without installing dependencies | ||
| * or running build processes. | ||
| */ |
Member
Author
There was a problem hiding this comment.
Just to highlight this for future reference, this comment is important.
There are restrictions on what you can do in this file.
Unfortunately those restriction are such that this is a FAUX ESM file!
yannbf
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
node_modulesare no longer installed, So I had to adapt a few things in order to make that work. I didn't want to re-introduce the install, because:.jsfiles.jsfiles individuallytypescriptpackage version andprettier, because I thought the problem I experienced were maybe due to those being outdated. (they were not, but I didn't feel like reverting that minor improvement)Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>