Skip to content

Testing github action changes #33070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ndelangen wants to merge 2 commits into from
Closed

Testing github action changes #33070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28fb7ec
perf(ci): remove local Danger Docker build and use ghcr.io runtime
yoshi-taka Nov 15, 2025
0085130
Merge branch 'next' into dangerfile
ndelangen Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .github/workflows/danger-js.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,8 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version-file: ".nvmrc"
- name: Danger JS
uses: danger/danger-js@11.2.6
uses: docker://ghcr.io/danger/danger-js:13.0.5
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
Expand Down
39 changes: 18 additions & 21 deletions scripts/dangerfile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,13 @@
import { execSync } from 'child_process';
import { danger, fail } from 'danger';
import pkg from '../code/package.json' assert { type: 'json' };

execSync('npm install lodash');
const intersection = (a: readonly string[], b: readonly string[]) =>
a.filter((v) => b.includes(v));

// eslint-disable-next-line depend/ban-dependencies
const flatten = require('lodash/flatten.js');
// eslint-disable-next-line depend/ban-dependencies
const intersection = require('lodash/intersection.js');
// eslint-disable-next-line depend/ban-dependencies
const isEmpty = require('lodash/isEmpty.js');

const pkg = require('../code/package.json');
type PrLogConfig = {
skipLabels?: string[];
validLabels?: [string, string][];
};
const prLogConfig = pkg['pr-log'];

const Versions = {
Expand All @@ -24,20 +21,20 @@ const ciLabels = ['ci:normal', 'ci:merged', 'ci:daily', 'ci:docs'];
const branchVersion = Versions.MINOR;

const checkRequiredLabels = (labels: string[]) => {
const forbiddenLabels = flatten([
const forbiddenLabels = [
'ci: do not merge',
'in progress',
branchVersion !== Versions.MAJOR ? 'BREAKING CHANGE' : [],
branchVersion === Versions.PATCH ? 'feature request' : [],
]);
...(branchVersion !== Versions.MAJOR ? ['BREAKING CHANGE'] : []),
...(branchVersion === Versions.PATCH ? ['feature request'] : []),
];

const requiredLabels = flatten([
prLogConfig.skipLabels || [],
(prLogConfig.validLabels || []).map((keyVal: string) => keyVal[0]),
]);
const requiredLabels = [
...(prLogConfig?.skipLabels ?? []),
...(prLogConfig?.validLabels ?? []).map(([label]) => label),
];

const blockingLabels = intersection(forbiddenLabels, labels);
if (!isEmpty(blockingLabels)) {
if (blockingLabels.length > 0) {
fail(
`PR is marked with ${blockingLabels.map((label: string) => `"${label}"`).join(', ')} label${
blockingLabels.length > 1 ? 's' : ''
Expand All @@ -46,14 +43,14 @@ const checkRequiredLabels = (labels: string[]) => {
}

const foundRequiredLabels = intersection(requiredLabels, labels);
if (isEmpty(foundRequiredLabels)) {
if (foundRequiredLabels.length === 0) {
fail(`PR is not labeled with one of: ${JSON.stringify(requiredLabels)}`);
} else if (foundRequiredLabels.length > 1) {
fail(`Please choose only one of these labels: ${JSON.stringify(foundRequiredLabels)}`);
}

const foundCILabels = intersection(ciLabels, labels);
if (isEmpty(foundCILabels)) {
if (foundCILabels.length === 0) {
fail(`PR is not labeled with one of: ${JSON.stringify(ciLabels)}`);
} else if (foundCILabels.length > 1) {
fail(`Please choose only one of these labels: ${JSON.stringify(foundCILabels)}`);
Expand Down