Skip to content

React Native Web: Fix react native resuables and nativewind#33056

Merged
shilman merged 1 commit into
storybookjs:nextfrom
dannyhw:dannyhw/fix/rnw-react-native-reusables
Nov 16, 2025
Merged

React Native Web: Fix react native resuables and nativewind#33056
shilman merged 1 commit into
storybookjs:nextfrom
dannyhw:dannyhw/fix/rnw-react-native-reusables

Conversation

@dannyhw
Copy link
Copy Markdown
Member

@dannyhw dannyhw commented Nov 16, 2025

Closes #

What I did

I updated the vite-plugin-rnw version to include fixes I've made for different react native libraries such as reusables and nativewind.

in this video I override the vite plugin version to test all the resuables components

rnresuables.mp4

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Chores
    • Updated build tool dependencies to the latest compatible versions for improved stability and performance.

@dannyhw dannyhw requested a review from shilman November 16, 2025 12:53
@dannyhw dannyhw added ci:normal maintenance User-facing maintenance tasks labels Nov 16, 2025
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Nov 16, 2025

View your CI Pipeline Execution ↗ for commit 4af5201

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 49s View ↗

☁️ Nx Cloud last updated this comment at 2025-11-16 13:15:50 UTC

@dannyhw dannyhw changed the title React Native Web: fixes for react native resuables and nativewind React Native Web: Fixes for react native resuables and nativewind Nov 16, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Nov 16, 2025

📝 Walkthrough

Walkthrough

Updated the vite-plugin-rnw dependency from ^0.0.8 to ^0.0.10 in the react-native-web-vite framework package configuration file.

Changes

Cohort / File(s) Summary
Dependency update
code/frameworks/react-native-web-vite/package.json
Updated vite-plugin-rnw version from ^0.0.8 to ^0.0.10

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Tip

📝 Customizable high-level summaries are now available!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide custom instructions to shape the summary (bullet lists, tables, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example:

"Create a concise high-level summary as a bullet-point list. Then include a Markdown table showing lines added and removed by each contributing author."


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3c27f14 and 4af5201.

⛔ Files ignored due to path filters (1)
  • code/yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • code/frameworks/react-native-web-vite/package.json (1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: Sidnioulz
Repo: storybookjs/storybook PR: 32458
File: code/core/src/components/components/Select/Select.tsx:200-204
Timestamp: 2025-11-05T09:38:47.712Z
Learning: Repo: storybookjs/storybook — Guidance: Until Storybook 11 is released, do not suggest using React.useId anywhere (e.g., in code/core/src/components/components/Select/Select.tsx) to maintain compatibility with React 17 runtimes. Prefer advising: accept a caller-provided props.id and, if needed, generate a client-only fallback id to minimize SSR hydration issues — but avoid useId. Resume prompting for useId after Storybook 11.
📚 Learning: 2025-10-02T09:22:13.215Z
Learnt from: JReinhold
Repo: storybookjs/storybook PR: 32607
File: code/package.json:243-243
Timestamp: 2025-10-02T09:22:13.215Z
Learning: The Storybook repository uses Yarn v^4 (any 4.x version) as the package manager, configured via .yarnrc.yml and package.json packageManager field. Specific patch versions within v4 can be upgraded as needed.

Applied to files:

  • code/frameworks/react-native-web-vite/package.json
📚 Learning: 2025-09-17T07:31:04.432Z
Learnt from: ndelangen
Repo: storybookjs/storybook PR: 32484
File: code/core/package.json:326-326
Timestamp: 2025-09-17T07:31:04.432Z
Learning: In Storybook's core package, dependencies like `open` are bundled into the final distribution during the build process, so they should remain in devDependencies rather than being moved to dependencies. End users don't need these packages as separate runtime dependencies since they're included in the bundled code.

Applied to files:

  • code/frameworks/react-native-web-vite/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: normal
  • GitHub Check: Core Unit Tests, windows-latest

Comment thread code/frameworks/react-native-web-vite/package.json
@shilman shilman changed the title React Native Web: Fixes for react native resuables and nativewind React Native Web: Fix react native resuables and nativewind Nov 16, 2025
@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Nov 16, 2025
@shilman shilman merged commit 7c943e1 into storybookjs:next Nov 16, 2025
61 of 73 checks passed
ndelangen pushed a commit that referenced this pull request Nov 17, 2025
…eusables

React Native Web: Fix react native resuables and nativewind

(cherry picked from commit 7c943e1)
@github-actions github-actions Bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:normal maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch react-native-web

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants