Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
1517a97
Enable syntax minification for dead code elimination
mrginglymus Nov 11, 2025
83b2b48
UI: Add VRTs to FileSearchModal in light theme
Sidnioulz Nov 12, 2025
c893150
Merge branch 'next' into pr/mrginglymus/33001
ndelangen Nov 12, 2025
1d9109d
we do not need this anymore, now that we're no longer minify
ndelangen Nov 12, 2025
b477d5e
remove comment
ndelangen Nov 12, 2025
4ee1283
regen lockfile
ndelangen Nov 12, 2025
cbbeac0
fix snapshots
ndelangen Nov 12, 2025
6f81144
sync esbuild versions
ndelangen Nov 12, 2025
1504c34
give errors an explicit name property, that cannot be compiled away
ndelangen Nov 12, 2025
5176096
fix
ndelangen Nov 12, 2025
e0e575e
Merge pull request #33022 from storybookjs/a11y/file-search-modal-lig…
yannbf Nov 12, 2025
50d8e1c
Merge branch 'next' into minify-syntax
ndelangen Nov 12, 2025
0d98abb
Update @storybook/icons dependency to version 2.0.0 across multiple p…
ndelangen Nov 13, 2025
b13be59
Merge pull request #33001 from mrginglymus/minify-syntax
ndelangen Nov 13, 2025
67da47d
bust cache, because scripts changed
ndelangen Nov 14, 2025
ae7fe5a
this got accidentally removed during the ESM-only work.
ndelangen Nov 14, 2025
9a8ce92
UNDO THIS! debug
yannbf Nov 14, 2025
96b8541
Revert "UNDO THIS! debug"
yannbf Nov 14, 2025
e64bfcc
experiment
yannbf Nov 14, 2025
2b1e00d
Merge pull request #33044 from storybookjs/norbert/bust-cache-2015-11-14
ndelangen Nov 14, 2025
5ab9e03
Merge branch 'next' into norbert/add-back-webcomponents-argtypes-entr…
ndelangen Nov 14, 2025
3c27f14
Merge pull request #33045 from storybookjs/norbert/add-back-webcompon…
ndelangen Nov 14, 2025
4af5201
React Native Web: fixes for react native resuables and nativewind
dannyhw Nov 16, 2025
7c943e1
Merge pull request #33056 from dannyhw/dannyhw/fix/rnw-react-native-r…
shilman Nov 16, 2025
fe130c4
Write changelog for 10.1.0-alpha.11 [skip ci]
storybook-bot Nov 16, 2025
25488b6
regen lockfile
ndelangen Nov 17, 2025
e749c3b
Update imports to disable dependency warnings for 'slash' in multiple…
ndelangen Nov 17, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.prerelease.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
## 10.1.0-alpha.11

- Maintenance: Enable syntax minification for dead code elimination - [#33001](https://github.com/storybookjs/storybook/pull/33001), thanks @mrginglymus!
- React Native Web: Fix react native resuables and nativewind - [#33056](https://github.com/storybookjs/storybook/pull/33056), thanks @dannyhw!
- UI: Add VRTs to FileSearchModal in light theme - [#33022](https://github.com/storybookjs/storybook/pull/33022), thanks @Sidnioulz!
- WebComponents: Fix `custom-elements.json` not being loaded - [#33045](https://github.com/storybookjs/storybook/pull/33045), thanks @ndelangen!

## 10.1.0-alpha.10

- Core: Significantly improve Storybook's own accessibility - [#32458](https://github.com/storybookjs/storybook/pull/32458), thanks @Sidnioulz!
Expand Down
4 changes: 2 additions & 2 deletions code/addons/a11y/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
},
"devDependencies": {
"@radix-ui/react-tabs": "1.0.4",
"@storybook/icons": "^1.6.0",
"@storybook/icons": "^2.0.0",
"@testing-library/react": "^14.0.0",
"execa": "^9.5.2",
"react": "^18.2.0",
Expand All @@ -79,7 +79,7 @@
"publishConfig": {
"access": "public"
},
"gitHead": "a8e7fd8a655c69780bc20b9749d2699e45beae17",
"gitHead": "a8e7fd8a655c69780bc20b9749d2699e45beae1l",
"storybook": {
"displayName": "Accessibility",
"icon": "https://user-images.githubusercontent.com/263385/101991665-47042f80-3c7c-11eb-8f00-64b5a18f498a.png",
Expand Down
4 changes: 2 additions & 2 deletions code/addons/docs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
"dependencies": {
"@mdx-js/react": "^3.0.0",
"@storybook/csf-plugin": "workspace:*",
"@storybook/icons": "^1.6.0",
"@storybook/icons": "^2.0.0",
"@storybook/react-dom-shim": "workspace:*",
"react": "^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0",
"react-dom": "^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0",
Expand Down Expand Up @@ -118,7 +118,7 @@
"publishConfig": {
"access": "public"
},
"gitHead": "a8e7fd8a655c69780bc20b9749d2699e45beae17",
"gitHead": "a8e7fd8a655c69780bc20b9749d2699e45beae1l",
"storybook": {
"displayName": "Docs",
"icon": "https://user-images.githubusercontent.com/263385/101991672-48355c80-3c7c-11eb-82d9-95fa12438f64.png",
Expand Down
2 changes: 1 addition & 1 deletion code/addons/links/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
"publishConfig": {
"access": "public"
},
"gitHead": "a8e7fd8a655c69780bc20b9749d2699e45beae17",
"gitHead": "a8e7fd8a655c69780bc20b9749d2699e45beae1l",
"storybook": {
"displayName": "Links",
"icon": "https://user-images.githubusercontent.com/263385/101991673-48355c80-3c7c-11eb-9b6e-b627c96a75f6.png",
Expand Down
2 changes: 1 addition & 1 deletion code/addons/onboarding/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
},
"devDependencies": {
"@neoconfetti/react": "^1.0.0",
"@storybook/icons": "^1.6.0",
"@storybook/icons": "^2.0.0",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-joyride": "^2.8.2",
Expand Down
2 changes: 1 addition & 1 deletion code/addons/pseudo-states/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"prep": "jiti ../../../scripts/build/build-package.ts"
},
"devDependencies": {
"@storybook/icons": "^1.6.0",
"@storybook/icons": "^2.0.0",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"typescript": "^5.8.3"
Expand Down
4 changes: 2 additions & 2 deletions code/addons/themes/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
"ts-dedent": "^2.0.0"
},
"devDependencies": {
"@storybook/icons": "^1.6.0",
"@storybook/icons": "^2.0.0",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"typescript": "^5.8.3"
Expand All @@ -72,7 +72,7 @@
"publishConfig": {
"access": "public"
},
"gitHead": "a8e7fd8a655c69780bc20b9749d2699e45beae17",
"gitHead": "a8e7fd8a655c69780bc20b9749d2699e45beae1l",
"storybook": {
"displayName": "Themes",
"unsupportedFrameworks": [
Expand Down
2 changes: 1 addition & 1 deletion code/addons/vitest/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
},
"dependencies": {
"@storybook/global": "^5.0.0",
"@storybook/icons": "^1.6.0",
"@storybook/icons": "^2.0.0",
"prompts": "^2.4.0",
"ts-dedent": "^2.2.0"
},
Expand Down
1 change: 1 addition & 0 deletions code/addons/vitest/src/node/vitest-manager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import type { StoryId, StoryIndex, StoryIndexEntry } from 'storybook/internal/ty

import * as find from 'empathic/find';
import path, { dirname, join, normalize } from 'pathe';
// eslint-disable-next-line depend/ban-dependencies
import slash from 'slash';

import { COVERAGE_DIRECTORY } from '../constants';
Expand Down
2 changes: 1 addition & 1 deletion code/builders/builder-vite/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -69,5 +69,5 @@
"publishConfig": {
"access": "public"
},
"gitHead": "a8e7fd8a655c69780bc20b9749d2699e45beae17"
"gitHead": "a8e7fd8a655c69780bc20b9749d2699e45beae1l"
}
1 change: 1 addition & 0 deletions code/builders/builder-vite/src/list-stories.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import type { Options } from 'storybook/internal/types';

// eslint-disable-next-line depend/ban-dependencies
import { glob } from 'glob';
// eslint-disable-next-line depend/ban-dependencies
import slash from 'slash';

export async function listStories(options: Options) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { relative } from 'node:path';

import type { BuilderStats } from 'storybook/internal/types';

// eslint-disable-next-line depend/ban-dependencies
import slash from 'slash';
import type { Plugin } from 'vite';

Expand Down
2 changes: 1 addition & 1 deletion code/builders/builder-webpack5/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -89,5 +89,5 @@
"publishConfig": {
"access": "public"
},
"gitHead": "a8e7fd8a655c69780bc20b9749d2699e45beae17"
"gitHead": "a8e7fd8a655c69780bc20b9749d2699e45beae1l"
}
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import type { Options, PreviewAnnotation } from 'storybook/internal/types';

import { toImportFn } from '@storybook/core-webpack';

// eslint-disable-next-line depend/ban-dependencies
import slash from 'slash';

import type { BuilderOptions } from '../types';
Expand Down
8 changes: 4 additions & 4 deletions code/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -196,13 +196,13 @@
},
"dependencies": {
"@storybook/global": "^5.0.0",
"@storybook/icons": "^1.6.0",
"@storybook/icons": "^2.0.0",
"@testing-library/jest-dom": "^6.6.3",
"@testing-library/user-event": "^14.6.1",
"@vitest/expect": "3.2.4",
"@vitest/mocker": "3.2.4",
"@vitest/spy": "3.2.4",
"esbuild": "^0.18.0 || ^0.19.0 || ^0.20.0 || ^0.21.0 || ^0.22.0 || ^0.23.0 || ^0.24.0 || ^0.25.0",
"esbuild": "^0.18.0 || ^0.19.0 || ^0.20.0 || ^0.21.0 || ^0.22.0 || ^0.23.0 || ^0.24.0 || ^0.25.0 || ^0.26.0 || ^0.27.0",
"recast": "^0.23.5",
"semver": "^7.6.2",
"use-sync-external-store": "^1.5.0",
Expand Down Expand Up @@ -279,7 +279,7 @@
"ejs": "^3.1.10",
"empathic": "^2.0.0",
"es-toolkit": "^1.36.0",
"esbuild": "^0.18.0 || ^0.19.0 || ^0.20.0 || ^0.21.0 || ^0.22.0 || ^0.23.0 || ^0.24.0 || ^0.25.0",
"esbuild": "^0.18.0 || ^0.19.0 || ^0.20.0 || ^0.21.0 || ^0.22.0 || ^0.23.0 || ^0.24.0 || ^0.25.0 || ^0.26.0 || ^0.27.0",
"execa": "^8.0.1",
"exsolve": "^1.0.7",
"fetch-retry": "^6.0.0",
Expand Down Expand Up @@ -352,5 +352,5 @@
"publishConfig": {
"access": "public"
},
"gitHead": "a8e7fd8a655c69780bc20b9749d2699e45beae17"
"gitHead": "a8e7fd8a655c69780bc20b9749d2699e45beae1l"
}
1 change: 1 addition & 0 deletions code/core/src/__tests/storybook-error.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ describe('StorybookError', () => {
class TestError extends StorybookError {
constructor(documentation?: StorybookError['documentation']) {
super({
name: 'TestError',
category: 'TEST_CATEGORY',
code: 123,
message: 'This is a test error.',
Expand Down
1 change: 1 addition & 0 deletions code/core/src/builder-manager/utils/files.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { mkdir, writeFile } from 'node:fs/promises';
import { dirname, join, normalize, relative } from 'node:path';

import type { OutputFile } from 'esbuild';
// eslint-disable-next-line depend/ban-dependencies
import slash from 'slash';

import type { Compilation } from '../types';
Expand Down
1 change: 1 addition & 0 deletions code/core/src/builder-manager/utils/managerEntries.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { dirname, join, parse, relative, sep } from 'node:path';

import { resolvePathInStorybookCache } from 'storybook/internal/common';

// eslint-disable-next-line depend/ban-dependencies
import slash from 'slash';

const sanitizeBase = (path: string) => {
Expand Down
1 change: 1 addition & 0 deletions code/core/src/common/utils/__tests__/paths.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { join, sep } from 'node:path';
import { describe, expect, it, vi } from 'vitest';

import * as find from 'empathic/find';
// eslint-disable-next-line depend/ban-dependencies
import slash from 'slash';

import { getProjectRoot, normalizeStoryPath } from '../paths';
Expand Down
1 change: 1 addition & 0 deletions code/core/src/common/utils/normalize-stories.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { InvalidStoriesEntryError } from 'storybook/internal/server-errors';
import type { NormalizedStoriesSpecifier, StoriesEntry } from 'storybook/internal/types';

import * as pico from 'picomatch';
// eslint-disable-next-line depend/ban-dependencies
import slash from 'slash';

import { globToRegexp } from './glob-to-regexp';
Expand Down
1 change: 1 addition & 0 deletions code/core/src/common/utils/strip-abs-node-modules-path.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { posix, sep } from 'node:path';

// eslint-disable-next-line depend/ban-dependencies
import slash from 'slash';

function normalizePath(id: string) {
Expand Down
1 change: 1 addition & 0 deletions code/core/src/common/utils/validate-configuration-files.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { MainFileMissingError } from 'storybook/internal/server-errors';

// eslint-disable-next-line depend/ban-dependencies
import { glob } from 'glob';
// eslint-disable-next-line depend/ban-dependencies
import slash from 'slash';
import { dedent } from 'ts-dedent';

Expand Down
1 change: 1 addition & 0 deletions code/core/src/core-server/utils/IndexingError.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// eslint-disable-next-line depend/ban-dependencies
import slash from 'slash';

export class IndexingError extends Error {
Expand Down
1 change: 1 addition & 0 deletions code/core/src/core-server/utils/StoryIndexGenerator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import type {

import * as find from 'empathic/find';
import picocolors from 'picocolors';
// eslint-disable-next-line depend/ban-dependencies
import slash from 'slash';
import invariant from 'tiny-invariant';
import { dedent } from 'ts-dedent';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { type StoriesEntry } from 'storybook/internal/types';

// eslint-disable-next-line depend/ban-dependencies
import { glob as globOriginal } from 'glob';
// eslint-disable-next-line depend/ban-dependencies
import slash from 'slash';

import { removeMDXEntries } from '../remove-mdx-entries';
Expand Down
1 change: 1 addition & 0 deletions code/core/src/core-server/utils/remove-mdx-entries.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import type { Options, StoriesEntry } from 'storybook/internal/types';

// eslint-disable-next-line depend/ban-dependencies
import { glob } from 'glob';
// eslint-disable-next-line depend/ban-dependencies
import slash from 'slash';

export async function removeMDXEntries(
Expand Down
1 change: 1 addition & 0 deletions code/core/src/core-server/utils/watch-story-specifiers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { basename, join, relative, resolve } from 'node:path';
import { commonGlobOptions } from 'storybook/internal/common';
import type { NormalizedStoriesSpecifier, Path } from 'storybook/internal/types';

// eslint-disable-next-line depend/ban-dependencies
import slash from 'slash';
import Watchpack from 'watchpack';

Expand Down
3 changes: 3 additions & 0 deletions code/core/src/manager-errors.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ export enum Category {
export class ProviderDoesNotExtendBaseProviderError extends StorybookError {
constructor() {
super({
name: 'ProviderDoesNotExtendBaseProviderError',
category: Category.MANAGER_UI,
code: 1,
message: `The Provider passed into Storybook's UI is not extended from the base Provider. Please check your Provider implementation.`,
Expand All @@ -37,6 +38,7 @@ export class UncaughtManagerError extends StorybookError {
}
) {
super({
name: 'UncaughtManagerError',
category: Category.MANAGER_UNCAUGHT,
code: 1,
message: data.error.message,
Expand All @@ -53,6 +55,7 @@ export class StatusTypeIdMismatchError extends StorybookError {
}
) {
super({
name: 'StatusTypeIdMismatchError',
category: Category.MANAGER_API,
code: 1,
message: `Status has typeId "${data.status.typeId}" but was added to store with typeId "${data.typeId}". Full status: ${JSON.stringify(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@ export const InitialState: Story = {
searchResults: null,
},
};
export const InitialStateLight = Object.assign({}, InitialState, {
globals: { sb_theme: 'light' },
});

export const Loading: Story = {
args: {
Expand All @@ -51,6 +54,7 @@ export const Loading: Story = {
searchResults: null,
},
};
export const LoadingLight = Object.assign({}, Loading, { globals: { sb_theme: 'light' } });

export const LoadingWithPreviousResults: Story = {
args: {
Expand All @@ -61,6 +65,9 @@ export const LoadingWithPreviousResults: Story = {
searchResults: WithResults.args.searchResults,
},
};
export const LoadingWithPreviousResultsLight = Object.assign({}, LoadingWithPreviousResults, {
globals: { sb_theme: 'light' },
});

export const Empty: Story = {
args: {
Expand All @@ -71,6 +78,7 @@ export const Empty: Story = {
searchResults: [],
},
};
export const EmptyLight = Object.assign({}, Empty, { globals: { sb_theme: 'light' } });

export const WithSearchResults: Story = {
args: {
Expand Down Expand Up @@ -99,6 +107,9 @@ export const WithSearchResults: Story = {
});
},
};
export const WithSearchResultsLight = Object.assign({}, WithSearchResults, {
globals: { sb_theme: 'light' },
});

export const WithSearchResultsAndError: Story = {
args: {
Expand All @@ -109,6 +120,9 @@ export const WithSearchResultsAndError: Story = {
searchResults: WithResults.args.searchResults,
},
};
export const WithSearchResultsAndErrorLight = Object.assign({}, WithSearchResultsAndError, {
globals: { sb_theme: 'light' },
});

export const WithSearchResultsAndMultiLineError: Story = {
args: {
Expand All @@ -122,3 +136,8 @@ export const WithSearchResultsAndMultiLineError: Story = {
searchResults: WithResults.args.searchResults,
},
};
export const WithSearchResultsAndMultiLineErrorLight = Object.assign(
{},
WithSearchResultsAndMultiLineError,
{ globals: { sb_theme: 'light' } }
);
1 change: 1 addition & 0 deletions code/core/src/preview-api/modules/store/autoTitle.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { once } from 'storybook/internal/client-logger';
import type { NormalizedStoriesSpecifier } from 'storybook/internal/types';

// eslint-disable-next-line depend/ban-dependencies
import slash from 'slash';
import { dedent } from 'ts-dedent';

Expand Down
Loading