Skip to content

Docs: Make Search FilledIn story content less confusing#33027

Merged
yannbf merged 1 commit into
nextfrom
a11y/make-search-story-less-confusing
Nov 25, 2025
Merged

Docs: Make Search FilledIn story content less confusing#33027
yannbf merged 1 commit into
nextfrom
a11y/make-search-story-less-confusing

Conversation

@Sidnioulz
Copy link
Copy Markdown
Contributor

@Sidnioulz Sidnioulz commented Nov 12, 2025

What I did

Changing copy in story that made us believe it was a placeholder in the past, when it's in fact a value.

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Tests
    • Updated component story examples: the "FilledIn" story now shows a different initial search query value ("Foo bar") to better reflect a sample filled state.
    • No runtime, control-flow, or exported API changes; this is a presentation-only update to the example content.

✏️ Tip: You can customize this high-level summary in your review settings.

@Sidnioulz Sidnioulz requested a review from yannbf November 12, 2025 13:05
@Sidnioulz Sidnioulz added maintenance User-facing maintenance tasks ci:normal labels Nov 12, 2025
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Nov 12, 2025

View your CI Pipeline Execution ↗ for commit 1b17317

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 44s View ↗

☁️ Nx Cloud last updated this comment at 2025-11-25 14:06:49 UTC

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Nov 12, 2025

📝 Walkthrough

Walkthrough

Updated a hardcoded string in a Storybook story: the initialQuery prop in the FilledIn story was changed from "Search query" to "Foo bar". No control flow, API, or exported declarations were modified.

Changes

Cohort / File(s) Change Summary
Storybook Story Update
code/core/src/manager/components/sidebar/Search.stories.tsx
Changed initialQuery prop in the FilledIn story from "Search query" to "Foo bar"; no other edits.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single-line, non-functional string change in a story file; verify the story renders as expected if reviewing visually.
✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1f6ab97 and 1b17317.

📒 Files selected for processing (1)
  • code/core/src/manager/components/sidebar/Search.stories.tsx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • code/core/src/manager/components/sidebar/Search.stories.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: normal
  • GitHub Check: Core Unit Tests, windows-latest

Comment @coderabbitai help to get the list of available commands and usage tips.

@yannbf yannbf added build Internal-facing build tooling & test updates and removed maintenance User-facing maintenance tasks labels Nov 12, 2025
@github-actions github-actions Bot added the Stale label Nov 25, 2025
@Sidnioulz Sidnioulz force-pushed the a11y/make-search-story-less-confusing branch from 923c245 to 1b17317 Compare November 25, 2025 13:46
@yannbf yannbf merged commit e2e9db9 into next Nov 25, 2025
67 checks passed
@yannbf yannbf deleted the a11y/make-search-story-less-confusing branch November 25, 2025 16:48
@github-actions github-actions Bot mentioned this pull request Nov 25, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:normal Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants