Skip to content

UI: Fix regression on addon panel empty content fontsize #33021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yannbf merged 4 commits into from
Nov 25, 2025
Merged

UI: Fix regression on addon panel empty content fontsize #33021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a0d3da9
UI: Fix regression on addon panel empty content fontsize
Sidnioulz Nov 12, 2025
c5fd0cf
Merge branch 'next' into a11y/addon-panel-font-size
yannbf Nov 12, 2025
860e8e8
UI: Avoid injecting an empty div
Sidnioulz Nov 12, 2025
651e0d6
Merge branch 'next' into a11y/addon-panel-font-size
yannbf Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion code/core/src/components/components/Tabs/EmptyTabContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ const Title = styled.div(({ theme }) => ({
color: theme.color.defaultText,
}));

const Footer = styled.div(({ theme }) => ({
fontSize: theme.typography.size.s2 - 1,
}));

const Description = styled.div(({ theme }) => ({
fontWeight: theme.typography.weight.regular,
fontSize: theme.typography.size.s2 - 1,
Expand All @@ -47,7 +51,7 @@ export const EmptyTabContent = ({ title, description, footer }: Props) => {
<Title>{title}</Title>
{description && <Description>{description}</Description>}
</Content>
{footer}
{footer && <Footer>{footer}</Footer>}
</Wrapper>
);
};
5 changes: 3 additions & 2 deletions code/core/src/components/components/addon-panel/addon-panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,10 @@ export interface AddonPanelProps {
hasScrollbar?: boolean;
}

const Div = styled.div({
const Div = styled.div(({ theme }) => ({
fontSize: theme.typography.size.s2 - 1,
height: '100%',
});
}));

export const AddonPanel = ({ active, children, hasScrollbar = true }: AddonPanelProps) => {
return (
Expand Down
Loading