Skip to content

Docs: Fix grammar in the monorepo readme#33008

Merged
jonniebigodes merged 2 commits into
storybookjs:nextfrom
WuMingDao:patch-1
Nov 17, 2025
Merged

Docs: Fix grammar in the monorepo readme#33008
jonniebigodes merged 2 commits into
storybookjs:nextfrom
WuMingDao:patch-1

Conversation

@WuMingDao
Copy link
Copy Markdown
Contributor

@WuMingDao WuMingDao commented Nov 11, 2025

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Documentation
    • Updated link text in README.md for improved clarity.

@valentinpalkovic valentinpalkovic added documentation ci:docs Run the CI jobs for documentation checks only. labels Nov 17, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Nov 17, 2025

📝 Walkthrough

Walkthrough

README.md updated with a textual change: the link text "learning interest" is pluralized to "learning interests". No behavioral or code-path modifications.

Changes

Cohort / File(s) Change Summary
Documentation
README.md
Link text updated from "learning interest" to "learning interests"

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minute


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2bc062f and 2943418.

📒 Files selected for processing (1)
  • README.md (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-11-05T09:38:47.712Z
Learnt from: Sidnioulz
Repo: storybookjs/storybook PR: 32458
File: code/core/src/components/components/Select/Select.tsx:200-204
Timestamp: 2025-11-05T09:38:47.712Z
Learning: Repo: storybookjs/storybook — Guidance: Until Storybook 11 is released, do not suggest using React.useId anywhere (e.g., in code/core/src/components/components/Select/Select.tsx) to maintain compatibility with React 17 runtimes. Prefer advising: accept a caller-provided props.id and, if needed, generate a client-only fallback id to minimize SSR hydration issues — but avoid useId. Resume prompting for useId after Storybook 11.

Applied to files:

  • README.md
🔇 Additional comments (1)
README.md (1)

174-174: LGTM!

The pluralization of "learning interest" to "learning interests" is grammatically correct and improves sentence parallelism with "skills." This is a straightforward documentation improvement.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jonniebigodes jonniebigodes changed the title documentation: fix grammar in readme.md Docs: Fix grammar in the monorepo readme Nov 17, 2025
Copy link
Copy Markdown
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WuMingDao, thank you for taking the time to put together this small pull request and helping us improve the documentation by catching this typo. Appreciate it 🙏 !

I've checked and all is good on my end.

I will merge once the checklist is cleared.

Have a great week.

Stay safe

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Nov 17, 2025

View your CI Pipeline Execution ↗ for commit 115540c

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 6s View ↗

☁️ Nx Cloud last updated this comment at 2025-11-17 17:07:20 UTC

@jonniebigodes jonniebigodes merged commit 84f7439 into storybookjs:next Nov 17, 2025
9 checks passed
@github-actions github-actions Bot mentioned this pull request Nov 18, 2025
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:docs Run the CI jobs for documentation checks only. documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants