Skip to content

don't use path.join for module specifiers #32889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
delagen wants to merge 1 commit into from
Closed

don't use path.join for module specifiers #32889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions code/core/src/cli/dirs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { join } from 'node:path';
import { join, posix } from 'node:path';
import { Readable } from 'node:stream';
import { pipeline } from 'node:stream/promises';
import type { ReadableStream } from 'node:stream/web';
Expand Down Expand Up @@ -53,7 +53,7 @@ export async function getRendererDir(
const frameworkPackageName =
externalFramework?.packageName || externalFramework?.renderer || `@storybook/${renderer}`;

const packageJsonPath = join(frameworkPackageName, 'package.json');
const packageJsonPath = posix.join(frameworkPackageName, 'package.json');

const errors: Error[] = [];

Expand Down
4 changes: 2 additions & 2 deletions code/core/src/core-server/build-dev.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { readFile } from 'node:fs/promises';
import { join, relative, resolve } from 'node:path';
import { join, posix, relative, resolve } from 'node:path';

import {
JsPackageManagerFactory,
Expand Down Expand Up @@ -115,7 +115,7 @@ export async function buildDevStandalone(
validateFrameworkName(frameworkName);
}
if (frameworkName) {
corePresets.push(join(frameworkName, 'preset'));
corePresets.push(posix.join(frameworkName, 'preset'));
}

frameworkName = frameworkName || 'custom';
Expand Down
4 changes: 2 additions & 2 deletions code/core/src/core-server/build-static.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { cp, mkdir } from 'node:fs/promises';
import { rm } from 'node:fs/promises';
import { join, relative, resolve } from 'node:path';
import { join, posix, relative, resolve } from 'node:path';

import {
loadAllPresets,
Expand Down Expand Up @@ -56,7 +56,7 @@ export async function buildStaticStandalone(options: BuildStaticStandaloneOption

const frameworkName = typeof framework === 'string' ? framework : framework?.name;
if (frameworkName) {
corePresets.push(join(frameworkName, 'preset'));
corePresets.push(posix.join(frameworkName, 'preset'));
} else if (!options.ignorePreview) {
logger.warn(`you have not specified a framework in your ${options.configDir}/main.js`);
}
Expand Down
4 changes: 2 additions & 2 deletions code/core/src/core-server/load.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { join, relative, resolve } from 'node:path';
import { join, posix, relative, resolve } from 'node:path';

import {
getProjectRoot,
Expand Down Expand Up @@ -39,7 +39,7 @@ export async function loadStorybook(
validateFrameworkName(frameworkName);
}
if (frameworkName) {
corePresets.push(join(frameworkName, 'preset'));
corePresets.push(posix.join(frameworkName, 'preset'));
}

frameworkName = frameworkName || 'custom';
Expand Down