Vite: Update optimizeViteDeps for addon-docs and addon-vitest#32881
Merged
Conversation
…eact' in preset.ts
|
View your CI Pipeline Execution ↗ for commit 02609c1
☁️ Nx Cloud last updated this comment at |
…bookjs/storybook into norbert/improve-optimizedeps-array
yannbf
approved these changes
Oct 29, 2025
This was referenced Oct 29, 2025
Merged
ndelangen
added a commit
that referenced
this pull request
Oct 30, 2025
…ps-array Vite: Update `optimizeViteDeps` for addon-docs and addon-vitest (cherry picked from commit b3d0932)
ndelangen
added a commit
that referenced
this pull request
Oct 30, 2025
…ps-array Vite: Update `optimizeViteDeps` for addon-docs and addon-vitest (cherry picked from commit b3d0932)
This was referenced Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
On a
pnpmproject created using:After init, press the "run tests" button and you'll see the following in the command-line:
I've adjusted the
optimizeDepssetting in addon-docs so this should not longer happen.I noticed together with @yannbf that the manually added
optimizeDepswere getting filtered out. This seemed wrong to us, because whatever is adding those includes, should make sure they are actually needed/valid.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Try a project WITH addon-vitest, but WITHOUT addon-docs, and check if the test complete correctly
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>