Skip to content

CLI: Fix glob string formatting in csf-factories codemod#32880

Merged
yannbf merged 1 commit into
nextfrom
yann/fix-csf-factories-pre-run
Oct 29, 2025
Merged

CLI: Fix glob string formatting in csf-factories codemod#32880
yannbf merged 1 commit into
nextfrom
yann/fix-csf-factories-pre-run

Conversation

@yannbf
Copy link
Copy Markdown
Member

@yannbf yannbf commented Oct 29, 2025

Closes #

What I did

As stated in the title. We were missing quotes and specifically with yarn dlx the command would fail.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Bug Fixes
    • Corrected glob pattern argument handling in the Storybook CSF migration process for more reliable file matching during migrations.

@yannbf yannbf self-assigned this Oct 29, 2025
@yannbf yannbf added bug cli ci:normal csf factories patch:yes Bugfix & documentation PR that need to be picked to main branch labels Oct 29, 2025
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Oct 29, 2025

View your CI Pipeline Execution ↗ for commit b416cd9

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 46s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-29 14:36:39 UTC

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Oct 29, 2025

View your CI Pipeline Execution ↗ for commit b416cd9

Command Status Duration Result
nx run-many -t build -c production --parallel=3 ✅ Succeeded 5s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-29 14:19:33 UTC

@coderabbitai

This comment was marked as spam.

@yannbf yannbf merged commit 1342fd5 into next Oct 29, 2025
61 of 63 checks passed
@yannbf yannbf deleted the yann/fix-csf-factories-pre-run branch October 29, 2025 14:59
ndelangen pushed a commit that referenced this pull request Oct 30, 2025
…-run

CLI: Fix glob string formatting in csf-factories codemod
(cherry picked from commit 1342fd5)
ndelangen pushed a commit that referenced this pull request Oct 30, 2025
…-run

CLI: Fix glob string formatting in csf-factories codemod
(cherry picked from commit 1342fd5)
@github-actions github-actions Bot added patch:done Patch/release PRs already cherry-picked to main/release branch labels Oct 30, 2025
@yannbf yannbf added the empathy label Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug ci:normal cli csf factories empathy patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants