Docs: Hotfix addon migration guide to match addon-kit#32847
Conversation
📝 WalkthroughWalkthroughThis pull request migrates an addon from CommonJS to ES Modules. Changes include updating TypeScript configuration to target ESM, converting package.json export mappings to ESM-style defaults, replacing CommonJS preset.js with ESM exports, updating local addon loading to use import.meta.resolve, and adjusting build configuration for ESM-first strategy. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (1)docs/**📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
🔇 Additional comments (6)
Comment |
|
View your CI Pipeline Execution ↗ for commit 4fb0dfb
☁️ Nx Cloud last updated this comment at |
jonniebigodes
left a comment
There was a problem hiding this comment.
@Sidnioulz, thanks for catching and adjusting the documentation. Appreciate it 🙏
I've checked, and everything is good on my end.
@ndelangen, if you don't have any objections, we can merge it and make it available as soon as the documentation is published.
What I did
Made changes to the addon migration guide to match recent changes made by @ndelangen on the addon-kit.
Checklist for Contributors
Testing
N/A
Documentation
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>Summary by CodeRabbit
Release Notes