Skip to content

Svelte: Fix snapshots in test#32840

Merged
ndelangen merged 1 commit into
nextfrom
norbert/fix-snapshot-svelte
Oct 26, 2025
Merged

Svelte: Fix snapshots in test#32840
ndelangen merged 1 commit into
nextfrom
norbert/fix-snapshot-svelte

Conversation

@ndelangen
Copy link
Copy Markdown
Member

@ndelangen ndelangen commented Oct 26, 2025

What I did

Update the snapshots.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

@ndelangen ndelangen changed the title Update Button component snapshots to reflect recent rendering changes Svelte: Fix snapshots in test Oct 26, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Oct 26, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • test-storybooks/portable-stories-kitchen-sink/svelte/stories/__snapshots__/Button.test.ts.snap is excluded by !**/*.snap

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch norbert/fix-snapshot-svelte

Comment @coderabbitai help to get the list of available commands and usage tips.

@ndelangen ndelangen self-assigned this Oct 26, 2025
@ndelangen ndelangen added cleanup Minor cleanup style change that won't show up in release changelog svelte ci:normal Run our default set of CI jobs (choose this for most PRs). labels Oct 26, 2025
@ndelangen ndelangen marked this pull request as ready for review October 26, 2025 10:14
@ndelangen ndelangen merged commit dd82ecf into next Oct 26, 2025
11 of 20 checks passed
@ndelangen ndelangen deleted the norbert/fix-snapshot-svelte branch October 26, 2025 10:15
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Oct 26, 2025

View your CI Pipeline Execution ↗ for commit f1801f6

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 45s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-26 10:31:42 UTC

@github-actions github-actions Bot mentioned this pull request Oct 26, 2025
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:normal Run our default set of CI jobs (choose this for most PRs). cleanup Minor cleanup style change that won't show up in release changelog svelte

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant