Skip to content

Migration: Add note about file URLs in SB10#32815

Merged
yannbf merged 3 commits into
nextfrom
shilman/add-file-url-migration-note
Oct 24, 2025
Merged

Migration: Add note about file URLs in SB10#32815
yannbf merged 3 commits into
nextfrom
shilman/add-file-url-migration-note

Conversation

@shilman
Copy link
Copy Markdown
Member

@shilman shilman commented Oct 23, 2025

Closes N/A

Documented a migration note that was missing when I upgraded Reshaped.


This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Documentation
    • Added migration guidance for converting URL-based paths to filesystem paths, with concrete before/after examples and clear steps for updating entry lists and configuration when switching path resolution methods.

@shilman shilman added documentation ci:docs Run the CI jobs for documentation checks only. labels Oct 23, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Oct 23, 2025

📝 Walkthrough

Walkthrough

Documentation updated to show how to resolve managerEntries paths when converting from a URL to a filesystem path, with concrete before/after examples using fileURLToPath(import.meta.resolve("./iframe.js")) and how to append iframe.js to the entry list.

Changes

Cohort / File(s) Summary
Storybook migration documentation
MIGRATION.md
Added guidance and concrete before/after examples for resolving managerEntries paths by converting URLs to filesystem paths using import.meta.resolve and fileURLToPath, and showed appending iframe.js to the entries.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch shilman/add-file-url-migration-note

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4dbc457 and 4ffbcf0.

📒 Files selected for processing (1)
  • MIGRATION.md (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • MIGRATION.md

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b68fa4a and 0db34bb.

📒 Files selected for processing (1)
  • MIGRATION.md (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Danger JS
  • GitHub Check: Core Unit Tests, windows-latest

Comment thread MIGRATION.md Outdated
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Oct 23, 2025

View your CI Pipeline Execution ↗ for commit a85170e

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 48s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-24 13:01:19 UTC

@shilman shilman added this to the 10 blocking milestone Oct 23, 2025
@shilman shilman force-pushed the shilman/add-file-url-migration-note branch from 0db34bb to 4dbc457 Compare October 23, 2025 18:04
Comment thread MIGRATION.md Outdated
@ndelangen ndelangen self-assigned this Oct 24, 2025
@yannbf yannbf merged commit bd7e6da into next Oct 24, 2025
10 checks passed
@yannbf yannbf deleted the shilman/add-file-url-migration-note branch October 24, 2025 14:09
@github-actions github-actions Bot mentioned this pull request Oct 24, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:docs Run the CI jobs for documentation checks only. documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants