Skip to content

React: Simplify version detection #32802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndelangen merged 4 commits into from
Oct 26, 2025
Merged

React: Simplify version detection #32802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
79e9835
Don't use semver lib for trivial version parsing
mrginglymus Oct 23, 2025
92e7ff4
Merge branch 'next' into no-semver-react
yannbf Oct 24, 2025
575ad04
Merge branch 'next' into no-semver-react
ndelangen Oct 26, 2025
ca35a93
Merge branch 'next' into no-semver-react
ndelangen Oct 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions code/renderers/react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@
"@types/escodegen": "^0.0.6",
"@types/estree": "^1.0.6",
"@types/node": "^22.0.0",
"@types/semver": "^7.3.4",
"acorn": "^7.4.1",
"acorn-jsx": "^5.3.1",
"acorn-walk": "^7.2.0",
Expand All @@ -73,7 +72,6 @@
"prop-types": "^15.7.2",
"react-element-to-jsx-string": "npm:@7rulnik/react-element-to-jsx-string@15.0.1",
"require-from-string": "^2.0.2",
"semver": "^7.3.7",
"ts-dedent": "^2.0.0",
"type-fest": "~2.19"
},
Expand Down
8 changes: 5 additions & 3 deletions code/renderers/react/src/entry-preview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import * as React from 'react';

import { global } from '@storybook/global';

import semver from 'semver';
import { configure } from 'storybook/test';

import { getAct, getReactActEnvironment, setReactActEnvironment } from './act-compat';
Expand All @@ -19,8 +18,11 @@ export const decorators: Decorator[] = [
return story();
}

const major = semver.major(React.version);
const minor = semver.minor(React.version);
const [major, minor] = React.version.split('.').map((part) => parseInt(part, 10));

if (!Number.isInteger(major) || !Number.isInteger(minor)) {
throw new Error('Unable to parse React version');
}
if (major < 18 || (major === 18 && minor < 3)) {
throw new Error('React Server Components require React >= 18.3');
}
Expand Down
2 changes: 0 additions & 2 deletions code/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6819,7 +6819,6 @@ __metadata:
"@types/escodegen": "npm:^0.0.6"
"@types/estree": "npm:^1.0.6"
"@types/node": "npm:^22.0.0"
"@types/semver": "npm:^7.3.4"
acorn: "npm:^7.4.1"
acorn-jsx: "npm:^5.3.1"
acorn-walk: "npm:^7.2.0"
Expand All @@ -6831,7 +6830,6 @@ __metadata:
prop-types: "npm:^15.7.2"
react-element-to-jsx-string: "npm:@7rulnik/react-element-to-jsx-string@15.0.1"
require-from-string: "npm:^2.0.2"
semver: "npm:^7.3.7"
ts-dedent: "npm:^2.0.0"
type-fest: "npm:~2.19"
peerDependencies:
Expand Down