Onboarding: Prevent confetti overlay from intercepting pointer events

[ghengeveld]

Closes #32657

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

• stories
• unit tests
• integration tests
• end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

• Add or update documentation reflecting your changes
• If you are deprecating/removing a feature, make sure to update
  MIGRATION.MD

Checklist for Maintainers

• When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

• Make sure this PR contains one of the labels below:

  Available labels

  • bug: Internal changes that fixes incorrect behavior.
  • maintenance: User-facing maintenance tasks.
  • dependencies: Upgrading (sometimes downgrading) dependencies.
  • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
  • cleanup: Minor cleanup style change. Will not show up in release changelog.
  • documentation: Documentation only changes. Will not show up in release changelog.
  • feature request: Introducing a new feature.
  • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
  • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

• New Features
  • Confetti now automatically hides 10 seconds after a successful save.
• Bug Fixes
  • Confetti overlay no longer intercepts clicks; interactions pass through to underlying elements.

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds a 10-second timeout to automatically hide confetti after a successful SAVE_STORY_RESPONSE and sets the confetti wrapper to ignore pointer events, leaving underlying UI interactive.

Changes

Cohort / File(s)	Summary
Onboarding success flow timing code/addons/onboarding/src/Onboarding.tsx	After handling SAVE_STORY_RESPONSE success, schedules setShowConfetti(false) after 10000 ms; no other logic paths altered.
Confetti overlay interaction code/addons/onboarding/src/components/Confetti/Confetti.tsx	Adds pointerEvents: 'none' to the wrapper to make the confetti layer non-interactive; no API changes.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant UI as Onboarding UI
  participant Store as Store/Effects
  participant Confetti as Confetti Overlay

  User->>UI: Trigger save action
  UI->>Store: SAVE_STORY (request)
  Store-->>UI: SAVE_STORY_RESPONSE (success)
  UI->>Confetti: setShowConfetti(true)
  rect rgba(200,255,200,0.2)
    note right of UI: Changed: schedule auto-hide
    UI-->>UI: setTimeout(10s)
  end
  UI->>Confetti: setShowConfetti(false) after 10s

  alt Error path (unchanged)
    Store-->>UI: SAVE_STORY_RESPONSE (error)
    UI-->>Confetti: no change
  end

  note over Confetti: Wrapper has pointerEvents: 'none'

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch windows-qa-files

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2e08667 and 12c4a69.

📒 Files selected for processing (2)

• code/addons/onboarding/src/Onboarding.tsx (1 hunks)
• code/addons/onboarding/src/components/Confetti/Confetti.tsx (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Adhere to ESLint and Prettier rules across all JS/TS source files

Files:

• code/addons/onboarding/src/components/Confetti/Confetti.tsx
• code/addons/onboarding/src/Onboarding.tsx

**/*.{ts,tsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Fix type errors and prefer precise typings instead of using any or suppressions, consistent with strict mode

Files:

• code/addons/onboarding/src/components/Confetti/Confetti.tsx
• code/addons/onboarding/src/Onboarding.tsx

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Danger JS
• GitHub Check: normal
• GitHub Check: Core Unit Tests, windows-latest

🔇 Additional comments (1)

code/addons/onboarding/src/components/Confetti/Confetti.tsx (1)

13-13: LGTM! Prevents confetti from blocking interactions.

Setting pointerEvents: 'none' on the confetti wrapper ensures the overlay doesn't intercept user interactions with the underlying UI, which is exactly what a purely visual celebration effect should do.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[nx-cloud]

View your CI Pipeline Execution ↗ for commit 12c4a69

Command	Status	Duration	Result
nx run-many -t build --parallel=3	✅ Succeeded	50s	View ↗

---

☁️ Nx Cloud last updated this comment at 2025-10-07 12:17:49 UTC