Move: Addon jest into it's own repository#32646
Merged
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughThis PR removes the Storybook Jest addon: all source, build/config, packaging, tests, docs, and references across core maps, build scripts, and test-storybook resolutions are deleted. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User as Developer
participant Preview as Storybook Preview
participant Decorator as withTests decorator
participant Channel as Channel
participant Manager as Manager Panel
rect rgba(220,235,255,0.6)
note over Preview,Decorator: Before removal
Developer->>Preview: Render story
Preview->>Decorator: Run withTests
Decorator->>Channel: Emit ADD_TESTS(tests)
Channel-->>Manager: Broadcast ADD_TESTS
Manager->>Manager: Render Tests panel
end
rect rgba(255,240,230,0.6)
note over Preview,Manager: After removal
Developer->>Preview: Render story
Preview-->>Preview: No withTests decorator
Note right of Channel: No ADD_TESTS events emitted
Manager->>Manager: No Tests panel registered
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related issues
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
Comment |
ndelangen
added
addon: jest
patch:yes
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
test-storybooks/portable-stories-kitchen-sink/vue3/package.json (2)
10-10: Remove obsolete Jest script (optional).Since the addon is removed and Jest isn’t used here, consider dropping the placeholder script.
- "jest": "echo 'Jest tests are not implemented!'",
61-61: Remove unused@testing-library/jest-dom— no imports or matcher calls found in this package; drop it from devDependencies.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
code/addons/jest/docs/storybook-addon-jest.gifis excluded by!**/*.gifcode/yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (30)
code/addons/jest/README.md(0 hunks)code/addons/jest/build-config.ts(0 hunks)code/addons/jest/manager.js(0 hunks)code/addons/jest/package.json(0 hunks)code/addons/jest/project.json(0 hunks)code/addons/jest/src/components/Message.tsx(0 hunks)code/addons/jest/src/components/Panel.tsx(0 hunks)code/addons/jest/src/components/Result.tsx(0 hunks)code/addons/jest/src/hoc/provideJestResult.tsx(0 hunks)code/addons/jest/src/index.ts(0 hunks)code/addons/jest/src/manager.tsx(0 hunks)code/addons/jest/src/shared.test.ts(0 hunks)code/addons/jest/src/shared.ts(0 hunks)code/addons/jest/src/types.ts(0 hunks)code/addons/jest/tsconfig.json(0 hunks)code/addons/jest/vitest.config.ts(0 hunks)code/core/src/common/versions.ts(0 hunks)code/core/src/core-server/__for-testing__/main.ts(0 hunks)code/package.json(0 hunks)scripts/.eslintignore(0 hunks)scripts/build/entry-configs.ts(0 hunks)test-storybooks/ember-cli/package.json(0 hunks)test-storybooks/external-docs/package.json(0 hunks)test-storybooks/portable-stories-kitchen-sink/nextjs/package.json(0 hunks)test-storybooks/portable-stories-kitchen-sink/react/package.json(0 hunks)test-storybooks/portable-stories-kitchen-sink/svelte/package.json(0 hunks)test-storybooks/portable-stories-kitchen-sink/vue3/package.json(1 hunks)test-storybooks/server-kitchen-sink/package.json(0 hunks)test-storybooks/standalone-preview/package.json(0 hunks)test-storybooks/yarn-pnp/package.json(0 hunks)
💤 Files with no reviewable changes (29)
- test-storybooks/external-docs/package.json
- code/core/src/core-server/for-testing/main.ts
- code/package.json
- code/addons/jest/src/types.ts
- test-storybooks/ember-cli/package.json
- scripts/.eslintignore
- code/addons/jest/vitest.config.ts
- scripts/build/entry-configs.ts
- code/addons/jest/package.json
- test-storybooks/standalone-preview/package.json
- code/addons/jest/src/components/Message.tsx
- test-storybooks/portable-stories-kitchen-sink/svelte/package.json
- code/addons/jest/build-config.ts
- code/addons/jest/src/index.ts
- test-storybooks/server-kitchen-sink/package.json
- test-storybooks/portable-stories-kitchen-sink/nextjs/package.json
- code/addons/jest/project.json
- code/addons/jest/src/components/Result.tsx
- test-storybooks/portable-stories-kitchen-sink/react/package.json
- code/addons/jest/tsconfig.json
- code/addons/jest/manager.js
- code/addons/jest/src/hoc/provideJestResult.tsx
- code/addons/jest/README.md
- test-storybooks/yarn-pnp/package.json
- code/core/src/common/versions.ts
- code/addons/jest/src/manager.tsx
- code/addons/jest/src/components/Panel.tsx
- code/addons/jest/src/shared.ts
- code/addons/jest/src/shared.test.ts
🧰 Additional context used
📓 Path-based instructions (1)
test-storybooks/**
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Maintain test configurations and assets under test-storybooks/ for Storybook testing
Files:
test-storybooks/portable-stories-kitchen-sink/vue3/package.json
🧠 Learnings (2)
📚 Learning: 2025-09-25T09:21:27.284Z
Learnt from: CR
PR: storybookjs/storybook#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-09-25T09:21:27.284Z
Learning: Applies to code/**/playwright.config.@(js|ts|mjs|cjs) : Use Playwright 1.52.0 for E2E tests and keep Playwright configuration aligned
Applied to files:
test-storybooks/portable-stories-kitchen-sink/vue3/package.json
📚 Learning: 2025-09-25T09:21:27.284Z
Learnt from: CR
PR: storybookjs/storybook#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-09-25T09:21:27.284Z
Learning: Applies to test-storybooks/** : Maintain test configurations and assets under test-storybooks/ for Storybook testing
Applied to files:
test-storybooks/portable-stories-kitchen-sink/vue3/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: normal
- GitHub Check: Danger JS
- GitHub Check: Core Unit Tests, windows-latest
🔇 Additional comments (2)
test-storybooks/portable-stories-kitchen-sink/vue3/package.json (2)
18-18: Playwright pinned to 1.52.0 — consistent with guidance.Also applies to: 52-52, 58-58
17-53: No remaining @storybook/addon-jest references—ready to merge Verified no code or config references remain.
|
View your CI Pipeline Execution ↗ for commit 1b756c7
☁️ Nx Cloud last updated this comment at |
Package BenchmarksCommit: No significant changes detected, all good. 👏 |
Contributor
|
@ndelangen curious to know where the addon will go from now on. Is it on I'll need to move some code from the a11y branch that fixes issues in the Jest addon's tabbar and aligns a few UI quirks on the rest of the UI. |
Contributor
|
@ndelangen I'll do a deeper search, but for now, docs-wise, it would be helpful to update the following files and references with the new location for the addon: I'll follow up with you on any other findings, or push a pull request myself once this is in. |
Member
Author
ndelangen
removed
the
patch:yes
7 tasks
8 tasks
This was referenced Oct 20, 2025
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Remove addon-jest from monorepo
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Summary by CodeRabbit