Skip to content

UI: Add proper focus outline to Button#32515

Merged
Sidnioulz merged 1 commit into
a11y-consolidationfrom
sidnioulz/fix-button-focus
Sep 22, 2025
Merged

UI: Add proper focus outline to Button#32515
Sidnioulz merged 1 commit into
a11y-consolidationfrom
sidnioulz/fix-button-focus

Conversation

@Sidnioulz
Copy link
Copy Markdown
Contributor

What I did

Added a thicker, WCAG compliant focus outline to Button which we seem to have missed :)

LMK what you think!

Before

image

After

image

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories

Manual testing

http://localhost:6006/?path=/story/button-component--pseudo-states&globals=sb_theme:side-by-side

Documentation

N/A

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@Sidnioulz Sidnioulz added ui maintenance User-facing maintenance tasks accessibility ci:normal a11y: keyboard Accessibility issues related to keyboard navigation or shortcuts a11y: contrast Accessibility issues related to contrast including Windows High Contrast Mode labels Sep 21, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Sep 21, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch sidnioulz/fix-button-focus

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Sep 21, 2025

View your CI Pipeline Execution ↗ for commit edc0177

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 48s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-21 15:35:55 UTC

@Sidnioulz Sidnioulz force-pushed the sidnioulz/fix-button-focus branch from bead711 to d87d5b3 Compare September 21, 2025 14:47
@Sidnioulz Sidnioulz force-pushed the sidnioulz/fix-button-focus branch from f61753a to edc0177 Compare September 21, 2025 15:11
Copy link
Copy Markdown
Contributor

@MichaelArestad MichaelArestad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks!

@Sidnioulz Sidnioulz merged commit cf97e2c into a11y-consolidation Sep 22, 2025
55 checks passed
@Sidnioulz Sidnioulz deleted the sidnioulz/fix-button-focus branch September 22, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a11y: contrast Accessibility issues related to contrast including Windows High Contrast Mode a11y: keyboard Accessibility issues related to keyboard navigation or shortcuts accessibility ci:normal maintenance User-facing maintenance tasks ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants