UI: Add WithMenu component [3/3]#32494
Closed
Sidnioulz wants to merge 12 commits into
Closed
Conversation
* Select was created * ToggleButton was created * IconButton was removed in favor of Button * Button and friends now require an ariaLabel and accept an optional ariaDescription * Button and friends now provide tooltip and shortcut props * All UI in the monorepo was ported to those changes
…tip-select-migration UI: Migrate Select from Popper.js tooltip to react-aria overlay
…tip-filesearch-ui-cleanup UI: Review FileSearchList tooltip behavior and align style with sidebar
… UI code BREAKING CHANGE: The WithTooltip API has significantly changed, and adjacent components WithTooltipPure and WithTooltipState were removed.
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Comment |
Sidnioulz
changed the title
|
View your CI Pipeline Execution ↗ for commit 22a7c27
☁️ Nx Cloud last updated this comment at |
Sidnioulz
force-pushed
the
a11y-consolidation
branch
3 times, most recently
from
166c0f2 to
d291255
Compare
Sidnioulz
force-pushed
the
a11y-consolidation
branch
from
d2cfdff to
05040c4
Compare
Contributor
|
This PR is quite out of date and has a ton of merge conflicts. I am closing it due to inactivity. Please feel free to reopen if you want to continue on it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #32492
Follows #32493
Closes #32236
What I did
I added a WithMenu component and a MenuItem implementing @MichaelArestad's current mockups.
Caution
@ghengeveld @MichaelArestad we still need to discuss the API for using menus:
Caution
Existing uses of Menu in our code have not yet been ported to this new API
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
unit testsManual testing
Documentation
N/A
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>