Skip to content

Release: Prerelease beta 10.0.0-beta.4#32474

Merged
ndelangen merged 6 commits into
next-releasefrom
version-non-patch-from-10.0.0-beta.3
Sep 16, 2025
Merged

Release: Prerelease beta 10.0.0-beta.4#32474
ndelangen merged 6 commits into
next-releasefrom
version-non-patch-from-10.0.0-beta.3

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented Sep 16, 2025

This is an automated pull request that bumps the version from 10.0.0-beta.3 to 10.0.0-beta.4.
Once this pull request is merged, it will trigger a new release of version 10.0.0-beta.4.
If you're not a core maintainer with permissions to release you can ignore this pull request.

To do

Before merging the PR, there are a few QA steps to go through:

  • Add the "freeze" label to this PR, to ensure it doesn't get automatically forced pushed by new changes.
  • Add the "ci:daily" label to this PR, to trigger the full test suite to run on this PR.

And for each change below:

  1. Ensure the change is appropriate for the version bump. E.g. patch release should only contain patches, not new or de-stabilizing features. If a change is not appropriate, revert the PR.
  2. Ensure the PR is labeled correctly with one of: "BREAKING CHANGE", "feature request", "bug", "maintenance", "dependencies", "documentation", "build", "unknown".
  3. Ensure the PR title is correct, and follows the format "[Area]: [Summary]", e.g. "React: Fix hooks in CSF3 render functions". If it is not correct, change the title in the PR.
    • Areas include: React, Vue, Core, Docs, Controls, etc.
    • First word of summary indicates the type: “Add”, “Fix”, “Upgrade”, etc.
    • The entire title should fit on a line

This is a list of all the PRs merged and commits pushed directly to next, that will be part of this release:

  • 📦 Dependencies: Replace: Use empathic over find-up #32472

If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.

Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.

When everything above is done:


Generated changelog

10.0.0-beta.4

  • Replace: Use empathic over find-up - #32472, thanks ndelangen!

@github-actions github-actions Bot added the release For PRs that trigger new releases. Automated label Sep 16, 2025
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

55 files reviewed, 6 comments

Edit Code Review Bot Settings | Greptile

}

const foundGitIgnoreFile = await findUp('.gitignore');
const foundGitIgnoreFile = find.up('.gitignore');
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Missing await keyword - find.up() likely returns a Promise but is being called synchronously

Suggested change
const foundGitIgnoreFile = find.up('.gitignore');
const foundGitIgnoreFile = await find.up('.gitignore');

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@beeequeue can you please look at the comments here?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empathic is all synchronous right?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it's all synchronous

Comment on lines +92 to +93
const deps = ['babel', 'empathic', 'fs'];
if (babel && find && fs) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Dependency mismatch: checks for 'empathic' in deps array but validates find variable existence. Should be consistent.

Suggested change
const deps = ['babel', 'empathic', 'fs'];
if (babel && find && fs) {
const deps = ['babel', 'find', 'fs'];
if (babel && find && fs) {

Comment on lines +59 to 60
vi.mocked(find.up).mockImplementation((name) =>
name === ('.svn' as any) ? '/path/to/root' : undefined
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax: Type assertion 'as any' is unnecessary since find.up accepts string parameters directly

Suggested change
vi.mocked(find.up).mockImplementation((name) =>
name === ('.svn' as any) ? '/path/to/root' : undefined
vi.mocked(find.up).mockImplementation((name) =>
name === '.svn' ? '/path/to/root' : undefined
);

Comment on lines +67 to 68
vi.mocked(find.up).mockImplementation((name) =>
name === ('.yarn' as any) ? '/path/to/root' : undefined
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: This test is checking for '.yarn' directory but the actual implementation in paths.ts doesn't search for '.yarn' directories - it searches for '.git', '.svn', '.hg' and then lock files via find.any()

Comment thread code/frameworks/react-vite/src/plugins/react-docgen.ts
@storybook-bot storybook-bot force-pushed the version-non-patch-from-10.0.0-beta.3 branch from e3f8ce1 to c202a3c Compare September 16, 2025 11:35
@github-actions github-actions Bot changed the title Release: Prerelease 10.0.0-beta.4 Release: Prerelease beta 10.0.0-beta.4 Sep 16, 2025
@ndelangen ndelangen added ci:daily Run the CI jobs that normally run in the daily job. freeze Freeze the Release PR with this label labels Sep 16, 2025
@ndelangen ndelangen self-assigned this Sep 16, 2025
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Sep 16, 2025

View your CI Pipeline Execution ↗ for commit da4a63e

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 54s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-16 14:17:55 UTC

@storybook-app-bot
Copy link
Copy Markdown

Package Benchmarks

Commit: da4a63e, ran on 16 September 2025 at 14:02:37 UTC

The following packages have significant changes to their size or dependencies:

@storybook/builder-vite

Before After Difference
Dependency count 11 11 0
Self size 374 KB 319 KB 🎉 -55 KB 🎉
Dependency size 1.30 MB 1.30 MB 🚨 +18 B 🚨
Bundle Size Analyzer Link Link

storybook

Before After Difference
Dependency count 48 48 0
Self size 30.74 MB 30.49 MB 🎉 -245 KB 🎉
Dependency size 17.64 MB 17.64 MB 0 B
Bundle Size Analyzer Link Link

@storybook/html-vite

Before After Difference
Dependency count 14 14 0
Self size 23 KB 23 KB 🎉 -2 B 🎉
Dependency size 1.71 MB 1.66 MB 🎉 -55 KB 🎉
Bundle Size Analyzer Link Link

@storybook/nextjs-vite

Before After Difference
Dependency count 130 124 🎉 -6 🎉
Self size 4.00 MB 4.00 MB 🎉 -38 B 🎉
Dependency size 21.66 MB 21.57 MB 🎉 -87 KB 🎉
Bundle Size Analyzer Link Link

@storybook/preact-vite

Before After Difference
Dependency count 14 14 0
Self size 14 KB 14 KB 🎉 -1 B 🎉
Dependency size 1.70 MB 1.64 MB 🎉 -55 KB 🎉
Bundle Size Analyzer Link Link

@storybook/react-native-web-vite

Before After Difference
Dependency count 163 157 🎉 -6 🎉
Self size 31 KB 31 KB 🎉 -15 B 🎉
Dependency size 23.04 MB 22.96 MB 🎉 -87 KB 🎉
Bundle Size Analyzer Link Link

@storybook/react-vite

Before After Difference
Dependency count 120 114 🎉 -6 🎉
Self size 36 KB 36 KB 🎉 -3 B 🎉
Dependency size 19.60 MB 19.51 MB 🎉 -87 KB 🎉
Bundle Size Analyzer Link Link

@storybook/svelte-vite

Before After Difference
Dependency count 22 22 0
Self size 59 KB 59 KB 0 B
Dependency size 26.95 MB 26.89 MB 🎉 -55 KB 🎉
Bundle Size Analyzer Link Link

@storybook/sveltekit

Before After Difference
Dependency count 23 23 0
Self size 49 KB 49 KB 🚨 +30 B 🚨
Dependency size 27.01 MB 26.95 MB 🎉 -55 KB 🎉
Bundle Size Analyzer Link Link

@storybook/vue3-vite

Before After Difference
Dependency count 110 109 🎉 -1 🎉
Self size 38 KB 38 KB 🎉 -79 B 🎉
Dependency size 43.82 MB 43.76 MB 🎉 -64 KB 🎉
Bundle Size Analyzer Link Link

@storybook/web-components-vite

Before After Difference
Dependency count 15 15 0
Self size 20 KB 20 KB 0 B
Dependency size 1.74 MB 1.68 MB 🎉 -55 KB 🎉
Bundle Size Analyzer Link Link

@storybook/cli

Before After Difference
Dependency count 205 205 0
Self size 879 KB 883 KB 🚨 +4 KB 🚨
Dependency size 82.03 MB 81.79 MB 🎉 -240 KB 🎉
Bundle Size Analyzer Link Link

@storybook/codemod

Before After Difference
Dependency count 174 174 0
Self size 35 KB 35 KB 0 B
Dependency size 77.10 MB 76.86 MB 🎉 -242 KB 🎉
Bundle Size Analyzer Link Link

create-storybook

Before After Difference
Dependency count 49 49 0
Self size 1.52 MB 1.52 MB 🚨 +2 KB 🚨
Dependency size 48.38 MB 48.13 MB 🎉 -245 KB 🎉
Bundle Size Analyzer node node

@storybook/preset-react-webpack

Before After Difference
Dependency count 170 170 0
Self size 26 KB 21 KB 🎉 -6 KB 🎉
Dependency size 30.84 MB 30.84 MB 🚨 +4 KB 🚨
Bundle Size Analyzer Link Link

@ndelangen ndelangen merged commit 995117b into next-release Sep 16, 2025
91 checks passed
@ndelangen ndelangen deleted the version-non-patch-from-10.0.0-beta.3 branch September 16, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:daily Run the CI jobs that normally run in the daily job. freeze Freeze the Release PR with this label release For PRs that trigger new releases. Automated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants