Release: Prerelease beta 10.0.0-beta.4#32474
Conversation
…empathic Replace: Use `empathic` over `find-up`
| } | ||
|
|
||
| const foundGitIgnoreFile = await findUp('.gitignore'); | ||
| const foundGitIgnoreFile = find.up('.gitignore'); |
There was a problem hiding this comment.
logic: Missing await keyword - find.up() likely returns a Promise but is being called synchronously
| const foundGitIgnoreFile = find.up('.gitignore'); | |
| const foundGitIgnoreFile = await find.up('.gitignore'); |
There was a problem hiding this comment.
@beeequeue can you please look at the comments here?
There was a problem hiding this comment.
empathic is all synchronous right?
There was a problem hiding this comment.
yes it's all synchronous
| const deps = ['babel', 'empathic', 'fs']; | ||
| if (babel && find && fs) { |
There was a problem hiding this comment.
logic: Dependency mismatch: checks for 'empathic' in deps array but validates find variable existence. Should be consistent.
| const deps = ['babel', 'empathic', 'fs']; | |
| if (babel && find && fs) { | |
| const deps = ['babel', 'find', 'fs']; | |
| if (babel && find && fs) { |
| vi.mocked(find.up).mockImplementation((name) => | ||
| name === ('.svn' as any) ? '/path/to/root' : undefined |
There was a problem hiding this comment.
syntax: Type assertion 'as any' is unnecessary since find.up accepts string parameters directly
| vi.mocked(find.up).mockImplementation((name) => | |
| name === ('.svn' as any) ? '/path/to/root' : undefined | |
| vi.mocked(find.up).mockImplementation((name) => | |
| name === '.svn' ? '/path/to/root' : undefined | |
| ); |
| vi.mocked(find.up).mockImplementation((name) => | ||
| name === ('.yarn' as any) ? '/path/to/root' : undefined |
There was a problem hiding this comment.
logic: This test is checking for '.yarn' directory but the actual implementation in paths.ts doesn't search for '.yarn' directories - it searches for '.git', '.svn', '.hg' and then lock files via find.any()
e3f8ce1 to
c202a3c
Compare
|
View your CI Pipeline Execution ↗ for commit da4a63e
☁️ Nx Cloud last updated this comment at |
…t reference for the `empathic` replacement
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 11 | 11 | 0 |
| Self size | 374 KB | 319 KB | 🎉 -55 KB 🎉 |
| Dependency size | 1.30 MB | 1.30 MB | 🚨 +18 B 🚨 |
| Bundle Size Analyzer | Link | Link |
storybook
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 48 | 48 | 0 |
| Self size | 30.74 MB | 30.49 MB | 🎉 -245 KB 🎉 |
| Dependency size | 17.64 MB | 17.64 MB | 0 B |
| Bundle Size Analyzer | Link | Link |
@storybook/html-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 14 | 14 | 0 |
| Self size | 23 KB | 23 KB | 🎉 -2 B 🎉 |
| Dependency size | 1.71 MB | 1.66 MB | 🎉 -55 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/nextjs-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 130 | 124 | 🎉 -6 🎉 |
| Self size | 4.00 MB | 4.00 MB | 🎉 -38 B 🎉 |
| Dependency size | 21.66 MB | 21.57 MB | 🎉 -87 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/preact-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 14 | 14 | 0 |
| Self size | 14 KB | 14 KB | 🎉 -1 B 🎉 |
| Dependency size | 1.70 MB | 1.64 MB | 🎉 -55 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-native-web-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 163 | 157 | 🎉 -6 🎉 |
| Self size | 31 KB | 31 KB | 🎉 -15 B 🎉 |
| Dependency size | 23.04 MB | 22.96 MB | 🎉 -87 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 120 | 114 | 🎉 -6 🎉 |
| Self size | 36 KB | 36 KB | 🎉 -3 B 🎉 |
| Dependency size | 19.60 MB | 19.51 MB | 🎉 -87 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/svelte-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 22 | 22 | 0 |
| Self size | 59 KB | 59 KB | 0 B |
| Dependency size | 26.95 MB | 26.89 MB | 🎉 -55 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/sveltekit
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 23 | 23 | 0 |
| Self size | 49 KB | 49 KB | 🚨 +30 B 🚨 |
| Dependency size | 27.01 MB | 26.95 MB | 🎉 -55 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/vue3-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 110 | 109 | 🎉 -1 🎉 |
| Self size | 38 KB | 38 KB | 🎉 -79 B 🎉 |
| Dependency size | 43.82 MB | 43.76 MB | 🎉 -64 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/web-components-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 15 | 15 | 0 |
| Self size | 20 KB | 20 KB | 0 B |
| Dependency size | 1.74 MB | 1.68 MB | 🎉 -55 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/cli
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 205 | 205 | 0 |
| Self size | 879 KB | 883 KB | 🚨 +4 KB 🚨 |
| Dependency size | 82.03 MB | 81.79 MB | 🎉 -240 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/codemod
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 174 | 174 | 0 |
| Self size | 35 KB | 35 KB | 0 B |
| Dependency size | 77.10 MB | 76.86 MB | 🎉 -242 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
create-storybook
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 49 | 49 | 0 |
| Self size | 1.52 MB | 1.52 MB | 🚨 +2 KB 🚨 |
| Dependency size | 48.38 MB | 48.13 MB | 🎉 -245 KB 🎉 |
| Bundle Size Analyzer | node | node |
@storybook/preset-react-webpack
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 170 | 170 | 0 |
| Self size | 26 KB | 21 KB | 🎉 -6 KB 🎉 |
| Dependency size | 30.84 MB | 30.84 MB | 🚨 +4 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
This is an automated pull request that bumps the version from
10.0.0-beta.3to10.0.0-beta.4.Once this pull request is merged, it will trigger a new release of version
10.0.0-beta.4.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next, that will be part of this release:empathicoverfind-up#32472If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
10.0.0-beta.4
empathicoverfind-up- #32472, thanks ndelangen!