CLI: Fix init not running dev when it should#32457
Merged
Merged
Conversation
dev when it should fixed
|
View your CI Pipeline Execution ↗ for commit 7c388ba
☁️ Nx Cloud last updated this comment at |
shilman
approved these changes
Sep 16, 2025
Member
Author
|
No, I assumed that that was intentional, because that was not changed recently. @kasperpeulen made it like that: |
Member
Author
|
@shilman The sandbox command uses that: So it's intentional: as a sandbox uses initiate, but shouldn't auto-dev |
23 tasks
dev when it should fixeddev when it should
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #32379
What I did
The wrong function was being used to init, causing only a subset of the procedure to run.
That caused the final step to not be called, thus
devwouldn't be executed.I modified the bin code so it imports the correct function
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Updated On: 2025-09-15 12:29:56 UTC
This PR fixes a critical bug in the Storybook CLI initialization process where the development server was not automatically launching after project setup when using
pnpm create storybook@next. The root cause was an incorrect import path in thecreate-storybookpackage's bin entry point.The key change is in
code/lib/create-storybook/src/bin/run.ts, where the import statement was corrected from importinginitiatefrom the package's top-level index (which exporteddoInitiate as initiate) to importinginitiatedirectly from theinitiate.tsfile. Based on the codebase context,doInitiateis an internal function that only performs the setup steps, whileinitiateis the complete public API wrapper that includes additional logic to launch the development server when appropriate.The change also includes cleanup in
build-config.tsby removing unused imports (joinfromnode:path). This fix ensures feature parity between the beta version (@next) and stable version (@latest) where the dev server was correctly starting after initialization, resolving the user experience issue where developers had to manually runstorybook devafter the init process completed.Confidence score: 4/5