Skip to content

Publish: Fix sentry in release yaml#32451

Merged
ndelangen merged 1 commit into
nextfrom
norbert/fix-sentry-action
Sep 15, 2025
Merged

Publish: Fix sentry in release yaml#32451
ndelangen merged 1 commit into
nextfrom
norbert/fix-sentry-action

Conversation

@ndelangen
Copy link
Copy Markdown
Member

@ndelangen ndelangen commented Sep 15, 2025

What I did

Fix a small error in the action yaml

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

Updated On: 2025-09-15 08:36:52 UTC

This PR fixes a critical issue in the Storybook publishing workflow by correcting the Sentry release action reference. The main change updates the deprecated sentry/action-release@v2 to the correct getsentry/action-release@v3 on line 194 of .github/workflows/publish.yml. This fix is essential because the Sentry action was referencing an incorrect organization - the official Sentry GitHub Action is published under the getsentry organization, not sentry.

The PR also includes minor cosmetic improvements by standardizing quote usage throughout the YAML file, changing from double quotes to single quotes for consistency. These changes affect the node-version-file property and Discord notification message, but don't impact functionality.

This change integrates with Storybook's release pipeline, which is responsible for publishing new versions and tracking releases in Sentry for error monitoring and deployment tracking. The workflow runs in the release environment and is triggered during the publishing process, making proper Sentry integration crucial for release visibility and debugging.

PR Description Notes:

  • The manual testing section is empty and should be filled out or explicitly state that no manual testing is necessary
  • No automated test coverage is indicated for these workflow changes
  • No labels have been applied yet (maintainers should add appropriate labels per the checklist)

Confidence score: 5/5

  • This PR is extremely safe to merge with virtually no risk of issues
  • Score reflects a simple, well-targeted fix of a clearly incorrect action reference with no complex logic changes
  • No files require special attention as this is a straightforward workflow correction

@ndelangen ndelangen changed the title Update GitHub Actions workflow: change node version file syntax and update Sentry action version Publish: Fix sentry in release yaml Sep 15, 2025
@ndelangen ndelangen added build Internal-facing build tooling & test updates ci:docs Run the CI jobs for documentation checks only. labels Sep 15, 2025
@ndelangen ndelangen self-assigned this Sep 15, 2025
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Sep 15, 2025

View your CI Pipeline Execution ↗ for commit 638cd7e

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 47s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-15 08:47:23 UTC

@ndelangen ndelangen marked this pull request as ready for review September 15, 2025 08:36
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Bot Settings | Greptile

@ndelangen ndelangen merged commit cc92eb4 into next Sep 15, 2025
15 of 18 checks passed
@ndelangen ndelangen deleted the norbert/fix-sentry-action branch September 15, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:docs Run the CI jobs for documentation checks only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant