CircleCI: Split workflows for unit and story tests#32446
Merged
Conversation
… and story tests. Added steps to run story tests and store results, ensuring better test organization and reporting.
|
View your CI Pipeline Execution ↗ for commit 5d08ff2
☁️ Nx Cloud last updated this comment at |
This was referenced Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #27018
What I did
This pull request updates the CircleCI configuration to improve test organization and reporting. The main changes introduce a dedicated job for running Storybook stories tests separately from unit tests, enhance test result reporting, and ensure both types of tests are executed in the CI workflows.
CircleCI configuration improvements:
stories-testsjob to run tests for files matching the*.stories.*pattern, separating them from standard unit tests for better clarity and parallelization.Workflow enhancements:
stories-testsjob into all relevant workflows, ensuring it runs after the build step alongside unit tests. [1] [2] [3]Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Updated On: 2025-09-12 09:57:07 UTC
This PR refactors the CircleCI configuration to separate story tests from unit tests into distinct jobs. The changes modify the existing
unit-testsjob to exclude story files by changing the test glob pattern from**/*.{test,spec,stories}.{ts,tsx,js,jsx,cjs}to**/*.{test,spec}.{ts,tsx,js,jsx,cjs}, removing the "stories" pattern. A newstories-testsjob is introduced that specifically targets story files with the pattern**/*.{stories}.{ts,tsx,js,jsx,cjs}and runs with parallelism set to 2 for better performance.The new
stories-testsjob uses thesb_playwrightexecutor with xlarge resource class and includes the same infrastructure as unit tests: test result storage, workflow failure reporting, and cancellation on failure. This job is integrated into all three CircleCI workflows (normal, merged, and daily), positioned to run after the build step alongside the existing unit tests.This architectural change aligns with the broader CI/CD strategy of the Storybook project, which already employs job separation for different test types (e2e-dev, e2e-production, e2e-ui). The separation enables better parallelization, clearer test result categorization, and more targeted debugging when specific test types fail. The change maintains the same test coverage while providing improved organization and potentially more reliable CI runs.
Confidence score: 4/5