Skip to content

React: Preserve @ts-expect-error in preview #32442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndelangen merged 2 commits into from
Sep 16, 2025
Merged

React: Preserve @ts-expect-error in preview #32442

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbb8f91
Preserve ts-expect-error
mrginglymus Sep 11, 2025
22d82d2
Merge branch 'next' into preserve-expect-error
ndelangen Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions code/renderers/react/src/preview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export function __definePreview<Addons extends PreviewAddon<never>[]>(
return preview;
}

// @ts-expect-error We cannot implement the meta faithfully here, but that is okay.
/** @ts-expect-error We cannot implement the meta faithfully here, but that is okay. */
export interface ReactPreview<T extends AddonTypes> extends Preview<ReactTypes & T> {
meta<
TArgs extends Args,
Expand Down Expand Up @@ -81,7 +81,7 @@ type DecoratorsArgs<TRenderer extends Renderer, Decorators> = UnionToIntersectio
>;

interface ReactMeta<T extends ReactTypes, MetaInput extends ComponentAnnotations<T>>
// @ts-expect-error hard
/** @ts-expect-error hard */
extends Meta<T, MetaInput> {
// Required args don't need to be provided when the user uses an empty render
story<
Expand All @@ -105,7 +105,7 @@ interface ReactMeta<T extends ReactTypes, MetaInput extends ComponentAnnotations
>,
>(
story?: TInput
// @ts-expect-error hard
/** @ts-expect-error hard */
): ReactStory<T, TInput>;
}

Expand Down
Loading