Skip to content

CSF: Enhance csf-factories codemods#32414

Merged
yannbf merged 1 commit into
feature/test-syntax-in-csffrom
yann/fix-csf-factories-codemods
Sep 4, 2025
Merged

CSF: Enhance csf-factories codemods#32414
yannbf merged 1 commit into
feature/test-syntax-in-csffrom
yann/fix-csf-factories-codemods

Conversation

@yannbf
Copy link
Copy Markdown
Member

@yannbf yannbf commented Sep 4, 2025

Closes #

What I did

This PR fixes two cases:

  • main.js/preview.js files with mixed exports e.g. named + default exports
  • stories as functions

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@yannbf yannbf self-assigned this Sep 4, 2025
@yannbf yannbf added bug csf ci:normal Run our default set of CI jobs (choose this for most PRs). labels Sep 4, 2025
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Sep 4, 2025

View your CI Pipeline Execution ↗ for commit 54ecd3a

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 13s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-04 17:05:24 UTC

@yannbf yannbf merged commit 41c83af into feature/test-syntax-in-csf Sep 4, 2025
50 of 55 checks passed
@yannbf yannbf deleted the yann/fix-csf-factories-codemods branch September 4, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug ci:normal Run our default set of CI jobs (choose this for most PRs). csf

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant