Skip to content

Core: Fix staticCopy not copying index.html to sub directory #32259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndelangen merged 2 commits into from
Aug 14, 2025
Merged

Core: Fix staticCopy not copying index.html to sub directory #32259

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f36a3e7
Fix skipPaths in copyAllStaticFilesRelativeToMain to reference output…
ndelangen Aug 13, 2025
32046f0
Update skipPaths in copyAllStaticFiles to use outputDir for correct f…
ndelangen Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions code/core/src/core-server/utils/copy-all-static-files.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export async function copyAllStaticFiles(staticDirs: any[] | undefined, outputDi
}

// Storybook's own files should not be overwritten, so we skip such files if we find them
const skipPaths = ['index.html', 'iframe.html'].map((f) => join(targetPath, f));
const skipPaths = ['index.html', 'iframe.html'].map((f) => join(outputDir, f));
await cp(staticPath, targetPath, {
dereference: true,
preserveTimestamps: true,
Expand Down Expand Up @@ -62,7 +62,7 @@ export async function copyAllStaticFilesRelativeToMain(
);

const targetPath = join(outputDir, to);
const skipPaths = ['index.html', 'iframe.html'].map((f) => join(targetPath, f));
const skipPaths = ['index.html', 'iframe.html'].map((f) => join(outputDir, f));
if (!from.includes('node_modules')) {
logger.info(
`=> Copying static files: ${picocolors.cyan(print(from))} at ${picocolors.cyan(print(targetPath))}`
Expand Down
Loading