Fix Symbol to string conversion error when passing React nodes as props in docs#32206
Closed
Copilot wants to merge 2 commits into
Closed
Fix Symbol to string conversion error when passing React nodes as props in docs#32206Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Co-authored-by: valentinpalkovic <5889929+valentinpalkovic@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [Bug]: Passing a React Node as a prop breaks docs in v9
Fix Symbol to string conversion error when passing React nodes as props in docs
Aug 6, 2025
Contributor
|
Superseded by #32220 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
getReactSymbolNamefunction in the React jsx decorator was causing "Cannot convert a Symbol value to a string" errors when React nodes were passed as props to components in Storybook v9 docs.Problem
When users passed React elements as props (e.g.,
<Button label={<span>Icon</span>} />), the docs page would break with a Symbol conversion error. This occurred because thegetReactSymbolNamefunction was callingtoString()on objects without proper error handling, leading to failures when:toStringmethod (likeObject.create(null))$$typeofproperty contained corrupted valuesSolution
Added robust error handling to the
getReactSymbolNamefunction:Changes Made
String()for problematic objectsTesting
Added test cases covering:
The fix is minimal, backwards-compatible, and preserves all existing functionality while preventing the Symbol conversion errors.
Fixes #32183.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
cloud.nx.app/usr/local/bin/node ./bin/post-install(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.