Release: Prerelease 9.2.0-alpha.2#32186
Conversation
Docs: Further improvements
Onboarding: Tweak referral wording in survey
github-actions
Bot
requested review from
jonniebigodes and
kylegach
as code owners
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| sb.mock(import('../lib/session.ts'), { spy: true }); | ||
| // 👇 Automatically spies on all exports from the `uuid` package in `node_modules` | ||
| sb.mock(import('uuid'), { spy: true }); |
There was a problem hiding this comment.
style: TypeScript version uses import() wrapper while JavaScript version uses string paths - this inconsistency might confuse users about when to use each approach
| sb.mock(import('../lib/session.ts')); | ||
| // 👇 Replaces imports of this module with imports to `../__mocks__/uuid.ts` | ||
| sb.mock(import('uuid')); |
There was a problem hiding this comment.
style: Inconsistent file extensions in comments - session.ts mock but uuid.ts for JavaScript package. Consider using .js for consistency in JS examples or clarify the extension handling.
| sb.mock('../lib/session.js'); | ||
| // 👇 Replaces imports of this module with imports to `../__mocks__/uuid.ts` | ||
| sb.mock('uuid'); |
There was a problem hiding this comment.
syntax: File extension mismatch: comment references session.ts and uuid.ts but the actual mock calls use .js extension. The comments should match the implementation.
| beforeEach: async () => { | ||
| // 👇 Force known, consistent behavior for mocked modules | ||
| uuidv4.mockReturnValue('1234-5678-90ab-cdef'); | ||
| getUserFromSession.mockReturnValue({ name: 'John Doe' }); |
There was a problem hiding this comment.
style: Inconsistent pattern: JavaScript examples directly call mock methods on imports while TypeScript examples use the mocked wrapper. This could confuse users about whether the wrapper is required or just for types.
|
|
||
| **Vite projects** | ||
|
|
||
| The root `__mocks__` directory should be placed in the [`root` directory](https://vite.dev/config/shared-options.html#root), as defined in your project's Vite configuration (typically `process.cwd()`) If that is unavailable, it defaults to the directory containing your `.storybook` directory. |
There was a problem hiding this comment.
syntax: Missing period after 'typically process.cwd())'
| The root `__mocks__` directory should be placed in the [`root` directory](https://vite.dev/config/shared-options.html#root), as defined in your project's Vite configuration (typically `process.cwd()`) If that is unavailable, it defaults to the directory containing your `.storybook` directory. | |
| The root `__mocks__` directory should be placed in the [`root` directory](https://vite.dev/config/shared-options.html#root), as defined in your project's Vite configuration (typically `process.cwd()`). If that is unavailable, it defaults to the directory containing your `.storybook` directory. |
CLI: Fixed broken migration guide link
storybook-bot
force-pushed
the
version-non-patch-from-9.2.0-alpha.1
branch
from
cee9c09 to
1277cb2
Compare
Docs: Add `afterEach` guidance
storybook-bot
force-pushed
the
version-non-patch-from-9.2.0-alpha.1
branch
from
1277cb2 to
0de3b31
Compare
Docs: Fix broken link in migration guide
storybook-bot
force-pushed
the
version-non-patch-from-9.2.0-alpha.1
branch
from
0de3b31 to
0a3dac7
Compare
CLI: Fix Docs migration link in migrations
storybook-bot
force-pushed
the
version-non-patch-from-9.2.0-alpha.1
branch
from
0a3dac7 to
738ca0c
Compare
yannbf
added
freeze
|
View your CI Pipeline Execution ↗ for commit 738ca0c
☁️ Nx Cloud last updated this comment at |
6 participants
This is an automated pull request that bumps the version from
9.2.0-alpha.1to9.2.0-alpha.2.Once this pull request is merged, it will trigger a new release of version
9.2.0-alpha.2.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next, that will be part of this release:afterEachguidance #32156 (will also be patched)If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
9.2.0-alpha.2