Skip to content

Docs: Update @storybook/icons#32144

Merged
valentinpalkovic merged 1 commit into
nextfrom
valentin/update-storybook-icons
Jul 28, 2025
Merged

Docs: Update @storybook/icons#32144
valentinpalkovic merged 1 commit into
nextfrom
valentin/update-storybook-icons

Conversation

@valentinpalkovic

@valentinpalkovic valentinpalkovic commented Jul 28, 2025

Copy link
Copy Markdown
Contributor

Closes #32143

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

This PR updates the @storybook/icons dependency in the docs addon from version ^1.2.12 to ^1.4.0 to resolve a version inconsistency issue. The change addresses a problem where multiple versions of @storybook/icons were being installed across different Storybook addons - the docs addon was using 1.2.12 while other addons like addon-vitest were using 1.4.0.

This type of dependency alignment is common in monorepo structures like Storybook's, where packages should use compatible versions of shared dependencies. The @storybook/icons package provides UI icons used throughout the Storybook interface, and having multiple versions installed can lead to bundle duplication and potential inconsistencies in the user interface. By aligning all addons to use the same version (1.4.0), this change eliminates the duplication and ensures consistent behavior across the Storybook ecosystem.

The change is purely a dependency version bump with no functional code changes, making it a straightforward maintenance update that resolves the version conflict flagged by Storybook's doctor tool.

PR Description Notes:

  • The "What I did" section is empty and should briefly describe the dependency update
  • No testing checkboxes are marked, though this type of change typically doesn't require new tests

Confidence score: 5/5

  • This PR is extremely safe to merge as it only updates a dependency version to align with other packages in the monorepo
  • The change resolves a known issue (duplicate dependencies) without introducing any functional changes or breaking compatibility
  • No files need additional attention - this is a single-line dependency version update

@valentinpalkovic valentinpalkovic self-assigned this Jul 28, 2025
@valentinpalkovic valentinpalkovic added dependencies addon: docs ci:normal Run our default set of CI jobs (choose this for most PRs). labels Jul 28, 2025

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Bot Settings | Greptile

@nx-cloud

nx-cloud Bot commented Jul 28, 2025

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit f346049

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 21s View ↗

☁️ Nx Cloud last updated this comment at 2025-07-28 13:17:38 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addon: docs ci:normal Run our default set of CI jobs (choose this for most PRs). dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: 9.1 beta - Inconsistent versions of @storybook/icons between addon docs and others

2 participants