Windows: Fix runtime and build-time errors#32116
Merged
Merged
Conversation
|
View your CI Pipeline Execution ↗ for commit 4a09205
☁️ Nx Cloud last updated this comment at |
ndelangen
approved these changes
Jul 24, 2025
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works on #31787
Fixes #32037
What I did
I QA'ed both a regular Storybook and the monorepo on Windows, and fixed some things:
C:\Jeppe Reinhold\dev\storybook), they need to be wrapped in double-quotesChecklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
This PR addresses critical Windows compatibility issues in Storybook's transition to ESM-only architecture. The changes fix two primary categories of problems that prevent Storybook from functioning correctly on Windows systems:
1. ESM Dynamic Import Path Resolution: Multiple files were updated to use
pathToFileURL()from Node.js'surlmodule when dynamically importing files with absolute paths. This is required because Node.js on Windows mandates that absolute paths in ESM dynamic imports must be converted to file URLs (e.g., convertingC:\path\file.jstofile:///C:/path/file.js). Files affected include telemetry modules, package managers (Yarn2Proxy, PNPMProxy), CLI utilities, and build scripts.2. Shell Command Path Quoting: Several files were modified to wrap file paths in double quotes when constructing shell commands for child processes. This prevents command execution failures when paths contain spaces, which is common on Windows (e.g.,
C:\Jeppe Reinhold\dev\storybook). Changes include CLI utilities, registry scripts, and sandbox management tools.Additional Improvements: The PR includes a fallback mechanism in sandbox creation that copies files when symlink operations fail (common on Windows without admin privileges), and updates some import statements to be more ESM-compliant.
These changes are essential for Storybook 10's ESM-only migration to work seamlessly across all platforms, particularly addressing the unique path handling requirements and filesystem limitations of Windows environments.
Confidence score: 3/5
code/frameworks/angular/src/server/angular-cli-webpack.jswhereisAbsolute()is used on file URLs instead of file paths, which will always return false and break Tailwind 4 detection.code/frameworks/angular/src/server/angular-cli-webpack.jsrequires immediate fix for theisAbsolute()usage with file URLs.