Skip to content

UI: Fix text color for failing stories in sidebar#32042

Merged
ghengeveld merged 1 commit into
nextfrom
fix-test-error-text-color
Jul 15, 2025
Merged

UI: Fix text color for failing stories in sidebar#32042
ghengeveld merged 1 commit into
nextfrom
fix-test-error-text-color

Conversation

@ghengeveld
Copy link
Copy Markdown
Member

@ghengeveld ghengeveld commented Jul 15, 2025

Closes #31462

What I did

Replaced wrong CSS text color for stories with error status in the sidebar, according to designs.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

This PR addresses an accessibility issue in Storybook's UI by changing the text color for failing stories in the sidebar from brown to #D43900 (a bright red). This change improves color contrast and visibility, particularly when using the Vitest addon under different theme configurations.

The modification is focused on the status.tsx file where the error status color is defined. This change enhances the user experience by making error states more visually distinct and maintaining better accessibility standards.

Confidence score: 4/5

  1. This is a safe UI-only change that affects color values
  2. The score reflects the straightforward nature of the change and its limited scope, with only minor uncertainty due to lack of unit tests
  3. Files needing attention:
    • code/core/src/manager/utils/status.tsx - Verify the new color works across all theme configurations

1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile

@ghengeveld ghengeveld requested a review from yannbf July 15, 2025 08:19
@ghengeveld ghengeveld self-assigned this Jul 15, 2025
@ghengeveld ghengeveld added bug patch:yes Bugfix & documentation PR that need to be picked to main branch ci:normal Run our default set of CI jobs (choose this for most PRs). labels Jul 15, 2025
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing changes made in this pull request

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Jul 15, 2025

View your CI Pipeline Execution ↗ for commit ddbd787

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 11s View ↗

☁️ Nx Cloud last updated this comment at 2025-07-15 08:41:51 UTC

@storybook-app-bot
Copy link
Copy Markdown

Package Benchmarks

Commit: ddbd787, ran on 15 July 2025 at 08:32:12 UTC

The following packages have significant changes to their size or dependencies:

storybook

Before After Difference
Dependency count 51 51 0
Self size 31.75 MB 31.76 MB 🚨 +15 KB 🚨
Dependency size 17.43 MB 17.43 MB 0 B
Bundle Size Analyzer Link Link

sb

Before After Difference
Dependency count 52 52 0
Self size 1 KB 1 KB 0 B
Dependency size 49.18 MB 49.20 MB 🚨 +15 KB 🚨
Bundle Size Analyzer Link Link

@storybook/cli

Before After Difference
Dependency count 217 217 0
Self size 582 KB 582 KB 0 B
Dependency size 93.66 MB 93.67 MB 🚨 +12 KB 🚨
Bundle Size Analyzer Link Link

@storybook/codemod

Before After Difference
Dependency count 186 186 0
Self size 31 KB 31 KB 0 B
Dependency size 77.76 MB 77.77 MB 🚨 +12 KB 🚨
Bundle Size Analyzer Link Link

@ghengeveld ghengeveld merged commit edbd7c4 into next Jul 15, 2025
56 of 58 checks passed
@ghengeveld ghengeveld deleted the fix-test-error-text-color branch July 15, 2025 08:43
ghengeveld added a commit that referenced this pull request Jul 15, 2025
UI: Fix text color for failing stories in sidebar
(cherry picked from commit edbd7c4)
@github-actions github-actions Bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jul 15, 2025
@ndelangen ndelangen removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug ci:normal Run our default set of CI jobs (choose this for most PRs). patch:done Patch/release PRs already cherry-picked to main/release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Vitest status values can cause color contrast issues on the sidebar

3 participants