Skip to content

Addons and renderers: Fix not being able to resolve package when referenced with getAbsolutePath#32034

Merged
JReinhold merged 3 commits into
sb10/esm-onlyfrom
jeppe/add-root-files
Jul 14, 2025
Merged

Addons and renderers: Fix not being able to resolve package when referenced with getAbsolutePath#32034
JReinhold merged 3 commits into
sb10/esm-onlyfrom
jeppe/add-root-files

Conversation

@JReinhold
Copy link
Copy Markdown
Contributor

@JReinhold JReinhold commented Jul 14, 2025

Works on #31787

What I did

Added back root preset.js/preview.js/manager.js entries to all addons and renderers where applicable.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

This PR restores root entry point files (preset.js, preview.js, manager.js) across multiple Storybook addons and renderers. These files serve as ESM re-export points that reference their corresponding compiled files in the dist directory. This change is essential for fixing package resolution issues when using getAbsolutePath, particularly in the context of Storybook's transition to ESM-only in version 10.

The change is being implemented consistently across various packages including:

  • Addons: a11y, docs, onboarding, pseudo-states, themes, vitest
  • Renderers: html, preact, react, server, svelte, vue3, web-components

Each added file follows the same pattern:

export * from './dist/{file-name}.js';

This change is part of a larger initiative to make Storybook ESM-only, which aims to reduce install size by 37% while maintaining proper module resolution and package compatibility.

Confidence score: 5/5

  1. This PR is extremely safe to merge as it follows a consistent, simple pattern across all changes
  2. The changes are minimal, focused, and only restore necessary entry points that were previously working
  3. The most attention should be paid to high-traffic packages like @storybook/react and @storybook/vue3 to ensure the re-exports are working as expected

20 files reviewed, no comments
Edit PR Review Bot Settings | Greptile

@JReinhold JReinhold self-assigned this Jul 14, 2025
@JReinhold JReinhold marked this pull request as ready for review July 14, 2025 11:04
@JReinhold JReinhold requested a review from ndelangen July 14, 2025 11:04
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing changes made in this pull request

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Jul 14, 2025

View your CI Pipeline Execution ↗ for commit b034fb2

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 53s View ↗

☁️ Nx Cloud last updated this comment at 2025-07-14 13:03:01 UTC

@JReinhold JReinhold merged commit d2353d9 into sb10/esm-only Jul 14, 2025
24 of 28 checks passed
@JReinhold JReinhold deleted the jeppe/add-root-files branch July 14, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants