Revert "Core: Fix FIPS compliance"#31986
Closed
ghengeveld wants to merge 1 commit into
Closed
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 file reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
| constructor(options: FileSystemCacheOptions = {}) { | ||
| this.prefix = (options.ns || options.prefix || '') + '-'; | ||
| this.hash_alg = options.hash_alg || 'sha256'; | ||
| this.hash_alg = options.hash_alg || 'md5'; |
Contributor
There was a problem hiding this comment.
logic: Reverting to MD5 will break Storybook in FIPS-compliant environments. Consider making SHA256 configurable rather than reverting.
Suggested change
| this.hash_alg = options.hash_alg || 'md5'; | |
| this.hash_alg = options.hash_alg || 'sha256'; |
Contributor
|
View your CI Pipeline Execution ↗ for commit 310d7f6
☁️ Nx Cloud last updated this comment at |
Package BenchmarksCommit: No significant changes detected, all good. 👏 |
ghengeveld
added
ci:daily
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #31806
Greptile Summary
Reverts the FIPS compliance fix that switched hashing from MD5 to SHA256 in FileSystemCache.
code/core/src/common/utils/file-cache.tsback to using MD5 instead of SHA256