Skip to content

Core: Improve addon detection in automigrations on windows #31937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valentinpalkovic merged 2 commits into from
Aug 11, 2025
Merged

Core: Improve addon detection in automigrations on windows #31937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
860f5fb
Fix addon detection in automigrations on windows
mrginglymus Jul 2, 2025
e0e4a3d
Merge branch 'next' into fix-addon-detection-windows
valentinpalkovic Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions code/core/src/common/utils/get-addon-names.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,18 @@ describe('getAddonNames', () => {
expect(result).toEqual(['@storybook/addon-highlight', '@storybook/addon-outline']);
});

it('should extract addon names from windows absolute paths', () => {
const config = {
stories: [],
addons: [
'\\sandbox\\react-vite-default-ts\\node_modules\\@storybook\\addon-highlight',
'\\sandbox\\react-vite-default-ts\\node_modules\\@storybook\\addon-outline',
],
};
const result = getAddonNames(config);
expect(result).toEqual(['@storybook/addon-highlight', '@storybook/addon-outline']);
});

it('should extract addon names from pnpm paths', () => {
const config = {
stories: [],
Expand Down
5 changes: 5 additions & 0 deletions code/core/src/common/utils/get-addon-names.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import type { StorybookConfig } from 'storybook/internal/types';

import { normalizePath } from './normalize-path';

export const getAddonNames = (mainConfig: StorybookConfig): string[] => {
const addons = mainConfig.addons || [];
const addonList = addons.map((addon) => {
Expand All @@ -14,6 +16,9 @@ export const getAddonNames = (mainConfig: StorybookConfig): string[] => {
return undefined;
}

// Ensure posix paths for plugin name sniffing
name = normalizePath(name);

// For absolute paths, pnpm and yarn pnp,
// Remove everything before and including "node_modules/"
name = name.replace(/.*node_modules\//, '');
Expand Down
Loading