Skip to content

CI: Temporarily disable Nuxt sandbox#31934

Merged
yannbf merged 1 commit into
nextfrom
disable-nuxt-sandbox
Jul 3, 2025
Merged

CI: Temporarily disable Nuxt sandbox#31934
yannbf merged 1 commit into
nextfrom
disable-nuxt-sandbox

Conversation

@ghengeveld
Copy link
Copy Markdown
Member

@ghengeveld ghengeveld commented Jul 2, 2025

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

Temporarily disables Nuxt v3 sandbox testing in CI pipeline to unblock workflow issues, with corresponding adjustments to test parallelization.

  • Commented out Nuxt v3 template definition in code/lib/cli-storybook/src/sandbox-templates.ts
  • Removed 'nuxt-vite/default-ts' from 'normal' templates list in sandbox configurations
  • Reduced parallelism counts in .circleci/config.yml for normal, merged, and daily workflows
  • Defensive change to maintain CI efficiency while underlying Nuxt-related issues are addressed

@ghengeveld ghengeveld requested review from ndelangen and yannbf July 2, 2025 14:14
@ghengeveld ghengeveld added build Internal-facing build tooling & test updates ci:normal labels Jul 2, 2025
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Jul 2, 2025

View your CI Pipeline Execution ↗ for commit 7b896c0.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 19s View ↗

☁️ Nx Cloud last updated this comment at 2025-07-03 09:42:55 UTC

@storybook-app-bot
Copy link
Copy Markdown

storybook-app-bot Bot commented Jul 2, 2025

Package Benchmarks

Commit: 7b896c0, ran on 3 July 2025 at 09:25:54 UTC

No significant changes detected, all good. 👏

@yannbf
Copy link
Copy Markdown
Member

yannbf commented Jul 2, 2025

As this issue will be fixed in the next release of Nuxt, we shouldn't merge this PR anymore

@ndelangen ndelangen closed this Jul 2, 2025
@yannbf yannbf reopened this Jul 3, 2025
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile

@yannbf yannbf merged commit 6871d0d into next Jul 3, 2025
57 of 74 checks passed
@yannbf yannbf deleted the disable-nuxt-sandbox branch July 3, 2025 09:27
@github-actions github-actions Bot mentioned this pull request Jul 3, 2025
71 tasks
@ghengeveld ghengeveld added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jul 7, 2025
@github-actions github-actions Bot mentioned this pull request Jul 7, 2025
18 tasks
ghengeveld pushed a commit that referenced this pull request Jul 8, 2025
CI: Temporarily disable Nuxt sandbox
(cherry picked from commit 6871d0d)
@github-actions github-actions Bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jul 8, 2025
@ndelangen ndelangen removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:normal patch:done Patch/release PRs already cherry-picked to main/release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants