Solid: Update links and docs for framework/renderer package#31928
Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
LGTM
49 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
valentinpalkovic
added
solid
ci:normal
documentation
ci:daily
shilman
changed the title
Package BenchmarksCommit: No significant changes detected, all good. 👏 |
|
View your CI Pipeline Execution ↗ for commit 0232855
☁️ Nx Cloud last updated this comment at |
jonniebigodes
approved these changes
Jul 5, 2025
Contributor
jonniebigodes
left a comment
jonniebigodes
left a comment
There was a problem hiding this comment.
@kachurun thanks for taking the time to put together this pull request and include the documentation updates. Appreciate it 🙏
From my end, all is good, but I'll defer to @shilman or @valentinpalkovic for the code changes.
Hope you have a great weekend.
Stay safe
Contributor
Author
|
Any updates guys? |
Contributor
Author
|
Guys? |
Contributor
Contributor
Author
|
Sure, thank you! |
shilman
added
the
patch:yes
Merged
13 tasks
14 tasks
yannbf
pushed a commit
that referenced
this pull request
Aug 11, 2025
Solid: Update links and docs for framework/renderer package (cherry picked from commit f763c86)
github-actions
Bot
added
the
patch:done
ndelangen
removed
the
patch:yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Updated links to SolidJS framework/renderer package.
See https://discord.com/channels/486522875931656193/1381354242333212693
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Updates all SolidJS framework references across Storybook documentation and configuration files to use 'storybook-solidjs-vite' instead of 'storybook-solidjs', reflecting the package's move to the solidjs-community organization.
code/core/src/cli/project_types.tsto align renderer and package name with new conventioncode/lib/cli-storybook/src/sandbox-templates.tsto use new package name and removed 'inDevelopment' flagcode/core/src/common/utils/get-storybook-info.ts