Deps: Extend vite peerDependencies range to include 7.0.0#31859
Merged
Conversation
Contributor
There was a problem hiding this comment.
LGTM
14 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
MrRefactoring
approved these changes
Jun 24, 2025
82c943b to
a98d6e0
Compare
|
View your CI Pipeline Execution ↗ for commit 474c2a9.
☁️ Nx Cloud last updated this comment at |
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 49 | 51 | 🚨 +2 🚨 |
| Self size | 31.85 MB | 31.73 MB | 🎉 -119 KB 🎉 |
| Dependency size | 17.41 MB | 17.43 MB | 🚨 +22 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
sb
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 50 | 52 | 🚨 +2 🚨 |
| Self size | 1 KB | 1 KB | 0 B |
| Dependency size | 49.26 MB | 49.16 MB | 🎉 -97 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/cli
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 216 | 218 | 🚨 +2 🚨 |
| Self size | 582 KB | 582 KB | 0 B |
| Dependency size | 94.88 MB | 94.81 MB | 🎉 -64 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/codemod
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 185 | 187 | 🚨 +2 🚨 |
| Self size | 31 KB | 31 KB | 0 B |
| Dependency size | 79.01 MB | 78.91 MB | 🎉 -97 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
create-storybook
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 1 | 1 | 0 |
| Self size | 12.47 MB | 12.50 MB | 🚨 +32 KB 🚨 |
| Dependency size | 98 KB | 98 KB | 0 B |
| Bundle Size Analyzer | Link | Link |
ndelangen
approved these changes
Jun 25, 2025
This was referenced Jun 25, 2025
Merged
ghengeveld
added a commit
that referenced
this pull request
Jun 27, 2025
Deps: Extend `vite` peerDependencies range to include `7.0.0` (cherry picked from commit 48e565a)
This was referenced Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Extends all peerDependency definitions for
viteto include7.0.0which was recently released. Additionally, it bumps Vitest to 3.2.4 as v3.2 is required for Vite 7.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>