Core: Fix addon scrollbars and align scrollbar colors with toolbars#31844
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses scrollbar theming issues by aligning scrollbar colors with toolbar styles and fixing related styling inconsistencies.
- Added scrollbar styling to Toolbar, Bar, and Tabs components.
- Updated the Bar component to accept a background color for scrollbar theming.
- Modified Subnav to integrate with the updated Bar component for consistent theming.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| code/core/src/manager/components/preview/Toolbar.tsx | Added scrollbarColor and scrollbarWidth for toolbar theming. |
| code/core/src/components/components/bar/bar.tsx | Introduced backgroundColor prop and updated minHeight and scrollbar styling; potential prop naming mismatch noted. |
| code/core/src/component-testing/components/Subnav.tsx | Updated to use useTheme and pass backgroundColor to Bar for theming. |
| code/addons/a11y/src/components/Tabs.tsx | Added scrollbar styling consistent with toolbar theming. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
4 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile
Sidnioulz
force-pushed
the
sidnioulz/scrollbar-batch-2
branch
from
9388095 to
5f39f43
Compare
|
View your CI Pipeline Execution ↗ for commit 5f39f43.
☁️ Nx Cloud last updated this comment at |
Contributor
|
No notes. This is great! |
ghengeveld
approved these changes
Jun 25, 2025
github-project-automation
Bot
moved this from Empathy Queue (prioritized)
to Done
in Core Team Projects
71 tasks
ghengeveld
added
the
patch:yes
Merged
8 tasks
ghengeveld
added a commit
that referenced
this pull request
Jun 27, 2025
Core: Fix addon scrollbars and align scrollbar colors with toolbars (cherry picked from commit e5a213a)
github-actions
Bot
added
the
patch:done
This was referenced Aug 18, 2025
This was referenced Aug 18, 2025
ndelangen
removed
the
patch:yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #31704.
I found other toolbars that had the same bug so I fixed them. Also changed the colours of toolbars to make it easier for end users to associate them with the toolbar and not the content below.
@MichaelArestad assigning you for a design review and for your general awareness of this theming use case. Currently using theme backgrounds and text foregrounds to colour the scrollbars until Theme 2.0.
What I did
Before
After
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
I don't think these are covered. There may be movement on some Chromatic tests though due to the changes affecting UI layout for two addons.
Manual testing
yarn storybook:uiand navigate to a storyDocumentation
N/A
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Updates scrollbar styling and toolbar theming across multiple Storybook components to improve visual consistency and usability of the UI.
code/core/src/components/components/bar/bar.tsxto add backgroundColor prop and flexible height with scrollbar theming supportcode/addons/a11y/src/components/Tabs.tsxto theme scrollbars using toolbar colors instead of default whitecode/core/src/manager/components/preview/Toolbar.tsxwith theme-aware scrollbar colors to match toolbar designcode/core/src/component-testing/components/Subnav.tsxto improve theme handling and toolbar color consistency