Docs: Fix incorrect vitest.setup.ts snippet#31838
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
LGTM
2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
|
View your CI Pipeline Execution ↗ for commit 69ac138
☁️ Nx Cloud last updated this comment at |
Contributor
|
@jonniebigodes Can you take a look? |
jonniebigodes
approved these changes
Jul 14, 2025
This was referenced Jul 14, 2025
Merged
ghengeveld
pushed a commit
that referenced
this pull request
Jul 15, 2025
Docs: Fix incorrect `vitest.setup.ts` snippet (cherry picked from commit c72e13e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fix incorrect inclusion of
vitest.beforeAllcall in examplevitest.setup.tsfile for the Vitest addon docsChecklist for Contributors
Testing
Manual testing
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.Greptile Summary
Updates Vitest addon documentation by removing incorrect
beforeAllhook from the setup example. This change improves accuracy and clarity of thevitest.setup.tsconfiguration file.vitest.beforeAllimport and call fromdocs/_snippets/addon-vitest-set-project-annotations-simple.mdportable-stories-vitest-set-project-annotations-simple.mdtoaddon-vitest-set-project-annotations-simple.mddocs/writing-tests/integrations/vitest-addon.mdxto reference the correctly named snippet file