Vite: Remove addon-themes and theming from optimized deps list

[ghengeveld]

Closes #31651

What I did

Removed @storybook/addon-themes and storybook/theming to avoid that Vite preoptimizes these dependencies, since only preview deps are supposed to be optimized, and these two are only meant to be used in the manager since they depend on React.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

• stories
• unit tests
• integration tests
• end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

• Add or update documentation reflecting your changes
• If you are deprecating/removing a feature, make sure to update
  MIGRATION.MD

Checklist for Maintainers

• When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

• Make sure this PR contains one of the labels below:

  Available labels

  • bug: Internal changes that fixes incorrect behavior.
  • maintenance: User-facing maintenance tasks.
  • dependencies: Upgrading (sometimes downgrading) dependencies.
  • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
  • cleanup: Minor cleanup style change. Will not show up in release changelog.
  • documentation: Documentation only changes. Will not show up in release changelog.
  • feature request: Introducing a new feature.
  • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
  • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-31833-sha-13bd9a49. Try it out in a new sandbox by running npx storybook@0.0.0-pr-31833-sha-13bd9a49 sandbox or in an existing project with npx storybook@0.0.0-pr-31833-sha-13bd9a49 upgrade.

More information

Published version	0.0.0-pr-31833-sha-13bd9a49
Triggered by	@ghengeveld
Repository	storybookjs/storybook
Branch	dont-optimize-manager-deps
Commit	13bd9a49
Datetime	Fri Jun 20 14:28:10 UTC 2025 (1750429690)
Workflow run	15781200308

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=31833

Greptile Summary

Optimizes Vite builder configuration by removing manager-only dependencies from pre-optimization list to prevent React dependency conflicts in non-React apps.

• Removed @storybook/addon-themes from Vite's optimization list as it's a manager-only dependency
• Removed storybook/theming from pre-optimization to avoid React conflicts in non-React apps
• Kept @storybook/addon-themes/preview in the optimization list since it's needed for preview functionality
• Fixes React dependency errors in Svelte applications ([Bug]: @storybook/addon-themes v9.0.4 has undeclared dependency on React #31651)
• Aligns with the principle that only preview dependencies should be pre-optimized

[greptile-apps]

LGTM

_{1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile}

[nx-cloud]

View your CI Pipeline Execution ↗ for commit 13bd9a4.

Command	Status	Duration	Result
nx run-many -t build --parallel=3	✅ Succeeded	1m 14s	View ↗

---

☁️ Nx Cloud last updated this comment at 2025-06-20 14:17:53 UTC