Skip to content

Core: Cleanup of type following up v9 and small verbatimModuleSyntax type fix #31823

Merged
ghengeveld merged 2 commits into
storybookjs:nextfrom
alcpereira:chore/fix-types
Jun 23, 2025
Merged

Core: Cleanup of type following up v9 and small verbatimModuleSyntax type fix #31823
ghengeveld merged 2 commits into
storybookjs:nextfrom
alcpereira:chore/fix-types

Conversation

@alcpereira
Copy link
Copy Markdown
Contributor

@alcpereira alcpereira commented Jun 19, 2025

What I did

   ✖  nx run svelte:check
      ====================================
      Loading svelte-check in workspace: /xxx/storybook/code/renderers/svelte
      Getting Svelte diagnostics...

      /xxx/storybook/code/renderers/svelte/../../core/src/actions/preview.ts:7:10
      Error: Re-exporting a type when 'verbatimModuleSyntax' is enabled requires using 'export type'.

      export { ActionsTypes };

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests
  • hopefully covered by type checking 🤞

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Those are TypeScript changes that should have no impact.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

Updates TypeScript type exports to support verbatimModuleSyntax and cleans up v9-related type definitions in core modules.

  • Modifies export { ActionsTypes } to use explicit export type in code/core/src/actions/preview.ts to fix verbatimModuleSyntax errors
  • Removes temporary Renderer interface that extended CSFRenderer in code/core/src/types/modules/csf.ts
  • Switches to direct export of Renderer type from storybook/internal/csf
  • Removes unnecessary CSFRenderer import for cleaner type definitions

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile

@valentinpalkovic valentinpalkovic added bug patch:yes Bugfix & documentation PR that need to be picked to main branch core typescript ci:normal labels Jun 23, 2025
@valentinpalkovic valentinpalkovic changed the title chore: cleanup of type following up v9 and small verbatimModuleSyntax type fix Core: Cleanup of type following up v9 and small verbatimModuleSyntax type fix Jun 23, 2025
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Jun 23, 2025

View your CI Pipeline Execution ↗ for commit 352914f.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 17s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-23 13:40:14 UTC

@storybook-app-bot
Copy link
Copy Markdown

Package Benchmarks

Commit: 352914f, ran on 23 June 2025 at 13:26:31 UTC

The following packages have significant changes to their size or dependencies:

storybook

Before After Difference
Dependency count 49 49 0
Self size 31.87 MB 31.85 MB 🎉 -16 KB 🎉
Dependency size 17.41 MB 17.41 MB 0 B
Bundle Size Analyzer Link Link

sb

Before After Difference
Dependency count 50 50 0
Self size 1 KB 1 KB 🎉 -20 B 🎉
Dependency size 49.27 MB 49.26 MB 🎉 -16 KB 🎉
Bundle Size Analyzer Link Link

@storybook/cli

Before After Difference
Dependency count 216 216 0
Self size 582 KB 582 KB 🎉 -20 B 🎉
Dependency size 95.13 MB 95.12 MB 🎉 -16 KB 🎉
Bundle Size Analyzer Link Link

@storybook/codemod

Before After Difference
Dependency count 185 185 0
Self size 31 KB 31 KB 0 B
Dependency size 79.26 MB 79.25 MB 🎉 -16 KB 🎉
Bundle Size Analyzer Link Link

@ghengeveld ghengeveld moved this to Empathy Queue (prioritized) in Core Team Projects Jun 23, 2025
@ghengeveld ghengeveld merged commit c0a5894 into storybookjs:next Jun 23, 2025
59 of 60 checks passed
@github-project-automation github-project-automation Bot moved this from Empathy Queue (prioritized) to Done in Core Team Projects Jun 23, 2025
@ghengeveld ghengeveld added patch:yes Bugfix & documentation PR that need to be picked to main branch and removed patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jun 24, 2025
@github-actions github-actions Bot mentioned this pull request Jun 25, 2025
8 tasks
@ghengeveld ghengeveld removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants