Cleanup: Fix links in package.json#31813
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
2 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile
| "storybook" | ||
| ], | ||
| "homepage": "https://github.com/storybookjs/storybook/tree/next/code/lib/cli", | ||
| "homepage": "https://github.com/storybookjs/storybook/tree/next/code/lib/cli-storybook", |
Contributor
There was a problem hiding this comment.
logic: The homepage path for the sb package should point to 'code/lib/cli-sb' instead of 'code/lib/cli-storybook' since this is the sb package
Suggested change
| "homepage": "https://github.com/storybookjs/storybook/tree/next/code/lib/cli-storybook", | |
| "homepage": "https://github.com/storybookjs/storybook/tree/next/code/lib/cli-sb", |
| "type": "git", | ||
| "url": "https://github.com/storybookjs/storybook.git", | ||
| "directory": "code/lib/cli" | ||
| "directory": "code/lib/cli-storybook" |
Contributor
There was a problem hiding this comment.
logic: The repository directory for the sb package should be 'code/lib/cli-sb' instead of 'code/lib/cli-storybook' to match its actual location
Suggested change
| "directory": "code/lib/cli-storybook" | |
| "directory": "code/lib/cli-sb" |
Hardanish-Singh
approved these changes
Jun 19, 2025
valentinpalkovic
approved these changes
Jun 20, 2025
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 49 | 49 | 0 |
| Self size | 31.85 MB | 31.87 MB | 🚨 +16 KB 🚨 |
| Dependency size | 17.41 MB | 17.41 MB | 0 B |
| Bundle Size Analyzer | Link | Link |
sb
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 50 | 50 | 0 |
| Self size | 1 KB | 1 KB | 🚨 +20 B 🚨 |
| Dependency size | 49.26 MB | 49.27 MB | 🚨 +16 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/cli
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 216 | 216 | 0 |
| Self size | 582 KB | 582 KB | 🚨 +20 B 🚨 |
| Dependency size | 94.58 MB | 94.59 MB | 🚨 +16 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/codemod
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 185 | 185 | 0 |
| Self size | 31 KB | 31 KB | 0 B |
| Dependency size | 78.71 MB | 78.72 MB | 🚨 +16 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
71 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#31800
Problem
The homepage and repository.directory fields in the package.json files of the following packages are incorrectly pointing to code/lib/cli:
@storybook/cli (code/lib/cli-storybook/package.json)
sb (code/lib/cli-sb/package.json)
This causes confusion when navigating the GitHub repository, as the links do not accurately reflect the location of the packages.
Incorrect Values:
homepage: https://github.com/storybookjs/storybook/tree/next/code/lib/cli
repository.directory: code/lib/cli
Fix
Updated both fields to correctly reference code/lib/cli-storybook:
code/lib/cli-storybook/package.json
diff
Copy
Edit
code/lib/cli-sb/package.json
diff
Copy
Edit
Files Affected:
code/lib/cli-storybook/package.json
code/lib/cli-sb/package.json
Checklist:
Updated homepage and repository.directory fields
Verified path accuracy for both packages
No other unrelated changes included
Greptile Summary
Updates package.json metadata fields to fix incorrect directory references, but introduces a new issue. While the PR correctly updates
@storybook/clipaths fromcode/lib/clitocode/lib/cli-storybook, it incorrectly applies the same path to thesbpackage which should point tocode/lib/cli-sbinstead.@storybook/clipackage.json to correctly referencecode/lib/cli-storybooksbpackage incorrectly points tocli-storybookinstead ofcli-sb