Skip to content

Sandbox: Override the right vitest.config file depending on language#31802

Merged
valentinpalkovic merged 1 commit into
nextfrom
valentin/fix-vitest-integration-tests
Jun 17, 2025
Merged

Sandbox: Override the right vitest.config file depending on language#31802
valentinpalkovic merged 1 commit into
nextfrom
valentin/fix-vitest-integration-tests

Conversation

@valentinpalkovic
Copy link
Copy Markdown
Contributor

@valentinpalkovic valentinpalkovic commented Jun 17, 2025

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

Updates sandbox-parts.ts to correctly handle Vitest configuration files based on the project's language, ensuring TypeScript and JavaScript sandboxes get the appropriate vitest.config file extensions.

  • Modified setupVitest function to use .ts or .js extensions based on sandbox language type
  • Prevents TypeScript config files from being used in JavaScript sandboxes which could cause test execution issues
  • Aligns with existing Vitest setup patterns shown in .storybook/vitest.setup.ts documentation
  • Improves integration test reliability by using language-appropriate configuration files

@valentinpalkovic valentinpalkovic self-assigned this Jun 17, 2025
@valentinpalkovic valentinpalkovic added build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job. labels Jun 17, 2025
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Jun 17, 2025

View your CI Pipeline Execution ↗ for commit 7e01aab.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 11s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-17 14:00:59 UTC

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Jun 17, 2025

View your CI Pipeline Execution ↗ for commit 7e01aab.

Command Status Duration Result
nx run-many -t build -c production --parallel=3 ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-17 13:56:22 UTC

@valentinpalkovic valentinpalkovic merged commit 3026f91 into next Jun 17, 2025
95 of 98 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/fix-vitest-integration-tests branch June 17, 2025 14:17
@github-actions github-actions Bot mentioned this pull request Jun 17, 2025
71 tasks
@github-actions github-actions Bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job. patch:done Patch/release PRs already cherry-picked to main/release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant