Skip to content

React Native: Fix window event listeners that dont exist on rn #31780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shilman merged 1 commit into from
Jun 16, 2025
Merged

React Native: Fix window event listeners that dont exist on rn #31780

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions code/core/src/preview-api/modules/preview-web/render/StoryRender.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,8 +316,8 @@ export class StoryRender<TRenderer extends Renderer> implements Render<TRenderer

// The phase should be 'rendering' but it might be set to 'aborted' by another render cycle
if (this.renderOptions.autoplay && forceRemount && playFunction && this.phase !== 'errored') {
window.addEventListener('error', onError);
window.addEventListener('unhandledrejection', onUnhandledRejection);
window?.addEventListener?.('error', onError);
window?.addEventListener?.('unhandledrejection', onUnhandledRejection);
this.disableKeyListeners = true;
try {
if (!isMountDestructured) {
Expand Down Expand Up @@ -360,8 +360,8 @@ export class StoryRender<TRenderer extends Renderer> implements Render<TRenderer
);
}
this.disableKeyListeners = false;
window.removeEventListener('unhandledrejection', onUnhandledRejection);
window.removeEventListener('error', onError);
window?.removeEventListener?.('unhandledrejection', onUnhandledRejection);
window?.removeEventListener?.('error', onError);

if (abortSignal.aborted) {
return;
Expand Down Expand Up @@ -473,7 +473,7 @@ export class StoryRender<TRenderer extends Renderer> implements Render<TRenderer
// If we still haven't completed, reload the page (iframe) to ensure we have a clean slate
// for the next render. Since the reload can take a brief moment to happen, we want to stop
// further rendering by awaiting a never-resolving promise (which is destroyed on reload).
window.location.reload();
window?.location?.reload?.();
await new Promise(() => {});
}
}
Loading