Skip to content

Nextjs-Vite: Use tsconfig paths plugin#31764

Merged
kasperpeulen merged 1 commit into
nextfrom
kasper/tsconfig-paths-vite-nextjs
Jun 13, 2025
Merged

Nextjs-Vite: Use tsconfig paths plugin#31764
kasperpeulen merged 1 commit into
nextfrom
kasper/tsconfig-paths-vite-nextjs

Conversation

@kasperpeulen
Copy link
Copy Markdown
Member

@kasperpeulen kasperpeulen commented Jun 12, 2025

Closes #31599

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-31764-sha-f043b02d. Try it out in a new sandbox by running npx storybook@0.0.0-pr-31764-sha-f043b02d sandbox or in an existing project with npx storybook@0.0.0-pr-31764-sha-f043b02d upgrade.

More information
Published version 0.0.0-pr-31764-sha-f043b02d
Triggered by @kasperpeulen
Repository storybookjs/storybook
Branch kasper/tsconfig-paths-vite-nextjs
Commit f043b02d
Datetime Thu Jun 12 14:28:37 UTC 2025 (1749738517)
Workflow run 15613330814

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=31764

Greptile Summary

Updates the vite-plugin-storybook-nextjs dependency in @storybook/nextjs-vite to add TypeScript path alias support through tsconfig paths plugin.

  • Updates vite-plugin-storybook-nextjs from v2.0.0 to v2.0.2--canary.41.5d54947.0 in code/frameworks/nextjs-vite/package.json
  • Enables automatic resolution of TypeScript path aliases in Next.js + Vite setup
  • Package contains critical path resolution functionality for Next.js Vite builder
  • PR needs completed issue number reference and testing documentation

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile

@kasperpeulen kasperpeulen added bug ci:normal Run our default set of CI jobs (choose this for most PRs). labels Jun 12, 2025
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Jun 12, 2025

View your CI Pipeline Execution ↗ for commit 5c69ac4.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 12s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-13 08:12:54 UTC

@storybook-app-bot
Copy link
Copy Markdown

Package Benchmarks

Commit: f043b02, ran on 12 June 2025 at 14:42:39 UTC

The following packages have significant changes to their size or dependencies:

@storybook/nextjs-vite

Before After Difference
Dependency count 128 131 🚨 +3 🚨
Self size 2.39 MB 2.39 MB 🚨 +21 B 🚨
Dependency size 22.14 MB 22.30 MB 🚨 +155 KB 🚨
Bundle Size Analyzer Link Link

@kasperpeulen kasperpeulen force-pushed the kasper/tsconfig-paths-vite-nextjs branch from f043b02 to 5c69ac4 Compare June 13, 2025 08:06
@kasperpeulen kasperpeulen added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jun 13, 2025
@kasperpeulen kasperpeulen merged commit d36aab5 into next Jun 13, 2025
4 of 8 checks passed
@kasperpeulen kasperpeulen deleted the kasper/tsconfig-paths-vite-nextjs branch June 13, 2025 08:07
@github-actions github-actions Bot mentioned this pull request Jun 13, 2025
4 tasks
shilman pushed a commit that referenced this pull request Jun 15, 2025
…-nextjs

Nextjs-Vite: Use tsconfig paths plugin
(cherry picked from commit d36aab5)
@github-actions github-actions Bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 15, 2025
@github-actions github-actions Bot mentioned this pull request Jun 16, 2025
71 tasks
@ndelangen ndelangen removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug ci:normal Run our default set of CI jobs (choose this for most PRs). patch:done Patch/release PRs already cherry-picked to main/release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: some tests failing on first run, but work seconds later (flakey, but consistent)

2 participants