Skip to content

Release Tooling: Dont at-mention users in release PR descriptions#31754

Merged
JReinhold merged 1 commit into
nextfrom
jeppe/dont-mention-in-releases
Jun 11, 2025
Merged

Release Tooling: Dont at-mention users in release PR descriptions#31754
JReinhold merged 1 commit into
nextfrom
jeppe/dont-mention-in-releases

Conversation

@JReinhold
Copy link
Copy Markdown
Contributor

@JReinhold JReinhold commented Jun 11, 2025

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

Modified release PR description generator to prevent unintentional user notifications by removing @ mentions in release descriptions.

  • Updated scripts/release/generate-pr-description.ts to remove @ mentions entirely instead of just adding spaces after them
  • Affects both generateReleaseDescription and generateNonReleaseDescription functions
  • Improves contributor experience by preventing accidental spam notifications during release PRs

@JReinhold JReinhold merged commit 69f8429 into next Jun 11, 2025
4 of 5 checks passed
@JReinhold JReinhold deleted the jeppe/dont-mention-in-releases branch June 11, 2025 19:08
@JReinhold JReinhold self-assigned this Jun 11, 2025
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile

@JReinhold JReinhold added build Internal-facing build tooling & test updates ci:docs Run the CI jobs for documentation checks only. labels Jun 11, 2025
@github-actions github-actions Bot mentioned this pull request Jun 11, 2025
71 tasks
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Jun 11, 2025

View your CI Pipeline Execution ↗ for commit 572200c.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 14s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-11 19:15:21 UTC

@JReinhold JReinhold added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jun 12, 2025
@github-actions github-actions Bot mentioned this pull request Jun 12, 2025
14 tasks
JReinhold added a commit that referenced this pull request Jun 12, 2025
…ases

Release Tooling: Dont at-mention users in release PR descriptions

(cherry picked from commit 69f8429)
@github-actions github-actions Bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 12, 2025
@ndelangen ndelangen removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:docs Run the CI jobs for documentation checks only. patch:done Patch/release PRs already cherry-picked to main/release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants