Skip to content

Angular: Update MiniCssExtractPlugin configuration for cache busting#31752

Merged
valentinpalkovic merged 1 commit into
nextfrom
valentin/cache-optimizations-for-angular-css
Jun 12, 2025
Merged

Angular: Update MiniCssExtractPlugin configuration for cache busting#31752
valentinpalkovic merged 1 commit into
nextfrom
valentin/cache-optimizations-for-angular-css

Conversation

@valentinpalkovic
Copy link
Copy Markdown
Contributor

@valentinpalkovic valentinpalkovic commented Jun 11, 2025

Closes #30225

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

Updates MiniCssExtractPlugin configuration in Angular framework preset to implement cache busting for CSS files by adding contenthash to filenames.

  • Added contenthash to CSS filenames in code/frameworks/angular/src/server/framework-preset-angular-cli.ts to prevent CDNs from serving outdated CSS
  • Implementation follows existing pattern used for JS and other asset types
  • Change addresses issue [Bug]: Generated CSS is erroneously cached #30225 where CDNs like Cloudflare were serving stale CSS after updates

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Jun 11, 2025

View your CI Pipeline Execution ↗ for commit efb6134.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 12s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-11 18:22:54 UTC

@valentinpalkovic valentinpalkovic added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jun 12, 2025
@valentinpalkovic valentinpalkovic merged commit fbf4523 into next Jun 12, 2025
62 of 68 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/cache-optimizations-for-angular-css branch June 12, 2025 06:26
@github-actions github-actions Bot mentioned this pull request Jun 12, 2025
14 tasks
@JReinhold JReinhold added the bug label Jun 12, 2025
JReinhold pushed a commit that referenced this pull request Jun 12, 2025
…ns-for-angular-css

Angular: Update MiniCssExtractPlugin configuration for cache busting
(cherry picked from commit fbf4523)
@github-actions github-actions Bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 12, 2025
@github-actions github-actions Bot mentioned this pull request Jun 16, 2025
71 tasks
@ndelangen ndelangen removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

angular bug ci:normal patch:done Patch/release PRs already cherry-picked to main/release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Generated CSS is erroneously cached

4 participants