Skip to content

Addon Docs: Fix reference to global JSX namespace#31671

Merged
kasperpeulen merged 2 commits into
storybookjs:nextfrom
mrginglymus:addon-docs-jsx
Jun 5, 2025
Merged

Addon Docs: Fix reference to global JSX namespace#31671
kasperpeulen merged 2 commits into
storybookjs:nextfrom
mrginglymus:addon-docs-jsx

Conversation

@mrginglymus

@mrginglymus mrginglymus commented Jun 5, 2025

Copy link
Copy Markdown
Contributor

What I did

Found another reference to the global JSX namespace that no longer exists in React 19+

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

Updates JSX type references in code/addons/docs/src/types.ts to ensure compatibility with React 19+ by replacing global JSX.Element with React.JSX.Element.

  • Modified type definitions in code/addons/docs/src/types.ts to use React.JSX.Element instead of global JSX.Element
  • Future-proofs the codebase for React 19 where global JSX namespace will be deprecated
  • Improves type safety by using the officially recommended JSX type reference pattern

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@nx-cloud

nx-cloud Bot commented Jun 5, 2025

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 8d9cc22.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 26s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-05 11:20:54 UTC

@kasperpeulen kasperpeulen added ci:normal Run our default set of CI jobs (choose this for most PRs). bug labels Jun 5, 2025
@storybook-app-bot

storybook-app-bot Bot commented Jun 5, 2025

Copy link
Copy Markdown

Package Benchmarks

Commit: 8d9cc22, ran on 5 June 2025 at 16:17:48 UTC

The following packages have significant changes to their size or dependencies:

@storybook/cli

Before After Difference
Dependency count 324 324 0
Self size 244 KB 244 KB 0 B
Dependency size 97.46 MB 97.75 MB 🚨 +295 KB 🚨
Bundle Size Analyzer Link Link

@storybook/codemod

Before After Difference
Dependency count 267 267 0
Self size 31 KB 31 KB 0 B
Dependency size 81.86 MB 82.16 MB 🚨 +295 KB 🚨
Bundle Size Analyzer Link Link

@kasperpeulen kasperpeulen merged commit d14a145 into storybookjs:next Jun 5, 2025
50 of 53 checks passed
@kasperpeulen kasperpeulen added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jun 5, 2025
@mrginglymus mrginglymus deleted the addon-docs-jsx branch June 5, 2025 16:10
@shilman shilman changed the title Docs: Fix reference to global JSX namespace Addon Docs: Fix reference to global JSX namespace Jun 7, 2025
shilman pushed a commit that referenced this pull request Jun 7, 2025
Docs: Fix reference to global JSX namespace
(cherry picked from commit d14a145)
@github-actions github-actions Bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 7, 2025
@ndelangen ndelangen removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug ci:normal Run our default set of CI jobs (choose this for most PRs). patch:done Patch/release PRs already cherry-picked to main/release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants