Core: Improve mono repo handling for JsPackageManager class and helpers by valentinpalkovic · Pull Request #31553 · storybookjs/storybook

valentinpalkovic · 2025-05-22T21:07:23Z

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

stories
unit tests
integration tests
end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

Add or update documentation reflecting your changes
If you are deprecating/removing a feature, make sure to update
MIGRATION.MD

Checklist for Maintainers

When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
- bug: Internal changes that fixes incorrect behavior.
- maintenance: User-facing maintenance tasks.
- dependencies: Upgrading (sometimes downgrading) dependencies.
- build: Internal-facing build tooling & test updates. Will not show up in release changelog.
- cleanup: Minor cleanup style change. Will not show up in release changelog.
- documentation: Documentation only changes. Will not show up in release changelog.
- feature request: Introducing a new feature.
- BREAKING CHANGE: Changes that break compatibility in some way with current major version.
- other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-31553-sha-1239c0fa. Try it out in a new sandbox by running npx storybook@0.0.0-pr-31553-sha-1239c0fa sandbox or in an existing project with npx storybook@0.0.0-pr-31553-sha-1239c0fa upgrade.

More information


Published version	`0.0.0-pr-31553-sha-1239c0fa`
Triggered by	@yannbf
Repository	storybookjs/storybook
Branch	`valentin/improve-monorepo-support-for-js-package-manager`
Commit	`1239c0fa`
Datetime	Fri May 23 13:33:04 UTC 2025 (`1748007184`)
Workflow run	15211552517

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=31553

Greptile Summary

This PR significantly improves monorepo support in the JsPackageManager class and related helpers, focusing on package management operations and configuration handling across multiple package.json files.

Introduced primaryPackageJson property to replace retrievePackageJson(), providing better monorepo-aware package.json handling
Changed getAllDependencies() from async to sync for improved performance and simplified dependency lookups
Added getModulePackageJSON() method with stopAt parameter to properly scope package searches in monorepos
Added --skip-install flag to CLI commands for better control over package installations in monorepo setups
Enhanced monorepo detection by checking for turbo.json, rush.json, nx.json, and workspaces configurations

nx-cloud · 2025-05-22T21:13:22Z

View your CI Pipeline Execution ↗ for commit 1239c0f.

Command	Status	Duration	Result
`nx run-many -t build --parallel=3`	✅ Succeeded	1m 27s	View ↗

☁️ Nx Cloud last updated this comment at 2025-05-23 13:33:01 UTC

greptile-apps

_{68 file(s) reviewed, 24 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2025-05-22T21:17:08Z

    'Force package manager for installing dependencies'
  )
  .option('-c, --config-dir <dir-name>', 'Directory where to load Storybook configurations from')
+  .option('--skip-install', 'Skip installing deps')


style: Consider using the same flag format as line 51 (-s) for consistency

greptile-apps · 2025-05-22T21:17:43Z

-  let mainConfig;
+  let storybookVersion: string | undefined;
+  let mainConfig: StorybookConfigRaw | undefined;
+  let packageManager!: JsPackageManager;


logic: Using definite assignment assertion (!) here could mask initialization errors if getStorybookData fails

greptile-apps · 2025-05-22T21:17:49Z

-  migration: any,
-  { glob, dryRun, list, rename, parser, configDir: userSpecifiedConfigDir }: CLIOptions
-) {
+export async function migrate(migration: any, { glob, dryRun, list, rename, parser }: CLIOptions) {


style: Migration parameter should be typed more specifically than 'any'

Suggested change

export async function migrate(migration: any, { glob, dryRun, list, rename, parser }: CLIOptions) {

export async function migrate(migration: string, { glob, dryRun, list, rename, parser }: CLIOptions) {

greptile-apps · 2025-05-22T21:17:50Z

-) {
+export async function migrate(migration: any, { glob, dryRun, list, rename, parser }: CLIOptions) {
  if (list) {
    listCodemods().forEach((key: any) => logger.log(key));


style: Key parameter in forEach callback should be typed more specifically than 'any'

Suggested change

listCodemods().forEach((key: any) => logger.log(key));

listCodemods().forEach((key: string) => logger.log(key));

greptile-apps · 2025-05-22T21:18:13Z

    // Users struggle to upgrade Storybook with npm because of conflicting peer-dependencies
    // GitHub Issue: https://github.com/storybookjs/storybook/issues/30306
    // Solution: Remove all Storybook packages (except 'storybook') from the package.json and install them again
+    // TODO: Check if this is still needed due to the resolution fix for the `storybook` package


style: Consider removing this TODO comment since the overrides fix is now implemented above

storybook-app-bot · 2025-05-22T21:21:27Z

Package Benchmarks

^{Commit: 1239c0f, ran on 23 May 2025 at 13:39:47 UTC}

The following packages have significant changes to their size or dependencies:

`@storybook/angular`

	Before	After	Difference
Dependency count	208	209	🚨 +1 🚨
Self size	606 KB	607 KB	🚨 +483 B 🚨
Dependency size	29.54 MB	29.56 MB	🚨 +11 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/ember`

	Before	After	Difference
Dependency count	208	205	🎉 -3 🎉
Self size	28 KB	28 KB	🚨 +179 B 🚨
Dependency size	28.82 MB	28.80 MB	🎉 -21 KB 🎉
Bundle Size Analyzer	Link	Link

`@storybook/nextjs`

	Before	After	Difference
Dependency count	534	531	🎉 -3 🎉
Self size	216 KB	216 KB	🚨 +10 B 🚨
Dependency size	58.69 MB	58.67 MB	🎉 -21 KB 🎉
Bundle Size Analyzer	Link	Link

`@storybook/nextjs-vite`

	Before	After	Difference
Dependency count	127	128	🚨 +1 🚨
Self size	2.39 MB	2.39 MB	0 B
Dependency size	22.05 MB	22.06 MB	🚨 +11 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/react-native-web-vite`

	Before	After	Difference
Dependency count	161	162	🚨 +1 🚨
Self size	35 KB	35 KB	0 B
Dependency size	23.21 MB	23.23 MB	🚨 +11 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/react-vite`

	Before	After	Difference
Dependency count	120	121	🚨 +1 🚨
Self size	32 KB	32 KB	🚨 +97 B 🚨
Dependency size	20.16 MB	20.17 MB	🚨 +11 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/react-webpack5`

	Before	After	Difference
Dependency count	284	286	🚨 +2 🚨
Self size	25 KB	25 KB	0 B
Dependency size	43.48 MB	43.50 MB	🚨 +15 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/preset-react-webpack`

	Before	After	Difference
Dependency count	175	177	🚨 +2 🚨
Self size	24 KB	24 KB	🚨 +171 B 🚨
Dependency size	30.32 MB	30.33 MB	🚨 +15 KB 🚨
Bundle Size Analyzer	Link	Link

…he project root

Core: Improve mono repo handling for JsPackageManager class and helpers

c13b712

valentinpalkovic added feature request ci:normal Run our default set of CI jobs (choose this for most PRs). labels May 22, 2025

valentinpalkovic self-assigned this May 22, 2025

valentinpalkovic commented May 22, 2025

View reviewed changes

Comment thread code/core/src/telemetry/storybook-metadata.test.ts Outdated

greptile-apps Bot reviewed May 22, 2025

View reviewed changes

valentinpalkovic and others added 9 commits May 22, 2025 23:23

Fix Angular sandbox

566b526

Remove unused import

4737b92

Fix types

6436065

Smaller fixes

5595040

Install at the end of automigrations

eac2647

Fix tests

69b3764

Core: Use projectRoot consequently and limit find-up actions to t…

ef8f4f2

…he project root

fix tests

b3e5ca2

Revert projectRoot usage to getProjectRoot

852679e

yannbf reviewed May 23, 2025

View reviewed changes

Comment thread code/core/src/common/js-package-manager/JsPackageManager.ts

yannbf reviewed May 23, 2025

View reviewed changes

Comment thread code/core/src/common/js-package-manager/JsPackageManager.ts Outdated

valentinpalkovic and others added 6 commits May 23, 2025 13:08

Fix initialization in empty directory + improvements in init

7edd821

Fix import and reference issues

034dbf6

Fix tests

4092bac

fix tests

480594b

fix test init flow

7becd44

Fix initialization in empty directory

1239c0f

yannbf approved these changes May 23, 2025

View reviewed changes

yannbf merged commit be484bf into valentin/monorepo-enhancements May 23, 2025
55 checks passed

yannbf deleted the valentin/improve-monorepo-support-for-js-package-manager branch May 23, 2025 14:01

dosubot Bot mentioned this pull request Jul 24, 2025

[Bug]: Storybook cannot be installed in a Stackblitz or Bolt.new environment #32117

Closed

	export async function migrate(migration: any, { glob, dryRun, list, rename, parser }: CLIOptions) {
	export async function migrate(migration: string, { glob, dryRun, list, rename, parser }: CLIOptions) {

	listCodemods().forEach((key: any) => logger.log(key));
	listCodemods().forEach((key: string) => logger.log(key));

Uh oh!

Conversation

valentinpalkovic commented May 22, 2025 • edited by storybook-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

Manual testing

Documentation

Checklist for Maintainers

🦋 Canary release

Greptile Summary

Uh oh!

Uh oh!

nx-cloud Bot commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot May 22, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot May 22, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot May 22, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot May 22, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot May 22, 2025

Choose a reason for hiding this comment

Uh oh!

storybook-app-bot Bot commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Package Benchmarks

@storybook/angular

@storybook/ember

@storybook/nextjs

@storybook/nextjs-vite

@storybook/react-native-web-vite

@storybook/react-vite

@storybook/react-webpack5

@storybook/preset-react-webpack

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

valentinpalkovic commented May 22, 2025 •

edited by storybook-bot

Loading

nx-cloud Bot commented May 22, 2025 •

edited

Loading

storybook-app-bot Bot commented May 22, 2025 •

edited

Loading

`@storybook/angular`

`@storybook/ember`

`@storybook/nextjs`

`@storybook/nextjs-vite`

`@storybook/react-native-web-vite`

`@storybook/react-vite`

`@storybook/react-webpack5`

`@storybook/preset-react-webpack`